Bug 227318

Summary: REGRESSION(r278970): A CATransaction commitHandler should not execute a client callback
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226257
https://bugs.webkit.org/show_bug.cgi?id=230085
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Description Said Abou-Hallawa 2021-06-23 14:31:28 PDT 
Because the client callback may cause directly or indirectly another CATransaction commitHandler to be added which is prohibited by CA.
Comment 1 Said Abou-Hallawa 2021-06-23 14:49:48 PDT 
<rdar://79625962>
Comment 2 Said Abou-Hallawa 2021-06-23 14:55:29 PDT 
Created attachment 432093 [details]
Patch
Comment 3 Tim Horton 2021-06-23 16:05:44 PDT 
Comment on attachment 432093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432093&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1248
> +            dispatch_async(dispatch_get_main_queue(), ^{

Likely better to use a lambda, like we do for addCommitHandler; replace the `^{` with `[callSnapshotRect = WTFMove(callSnapshotRect)] {`
Comment 4 Said Abou-Hallawa 2021-06-23 17:07:49 PDT 
Created attachment 432115 [details]
Patch
Comment 5 EWS 2021-06-23 22:27:39 PDT 
Committed r279210 (239096@main): <https://commits.webkit.org/239096@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432115 [details].