Summary: | Unskip deltablue-for-of.js on arm and mips | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail R. Gadelha <mikhail> | ||||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | angelos, ticaiolima, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Mikhail R. Gadelha
2021-06-23 07:47:02 PDT
Created attachment 432040 [details]
Patch
Created attachment 432050 [details]
Patch
Comment on attachment 432050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432050&action=review > JSTests/ChangeLog:10 > + number of iterations and constraints. Is it safe to to for all architectures. If so, that’s good. Otherwise, maybe it’s possible to conditionally change values for ARMv7 and MIPS. Yeah, so the updated test case doesn't timeout in neither mips or arm with more than 50 iterations tested. There doesn't seem to timeout in any other EWS bot either. Created attachment 438697 [details]
Patch
Created attachment 438809 [details]
Patch
Created attachment 443315 [details]
Patch
Created attachment 443578 [details]
Patch
Committed r285490 (244014@main): <https://commits.webkit.org/244014@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443578 [details]. |