Bug 227278

Summary: Message dropped when restoring webpages.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Megan Gardner
Reported 2021-06-22 22:02:21 PDT
Message dropped when restoring webpages.
Attachments
Patch (1.72 KB, patch)
2021-06-22 22:07 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-06-22 22:07:43 PDT
Created attachment 432018 [details] Patch
Tim Horton
Comment 2 2021-06-22 22:12:57 PDT
Comment on attachment 432018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432018&action=review > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:615 > setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden); > }; You could shove this block inline instead of in a local, now, if you wanted. But this is fine too.
Megan Gardner
Comment 3 2021-06-22 22:35:51 PDT
I liked it and left it on purpose ;P
EWS
Comment 4 2021-06-22 23:34:37 PDT
Committed r279166 (239063@main): <https://commits.webkit.org/239063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432018 [details].
Radar WebKit Bug Importer
Comment 5 2021-06-22 23:35:17 PDT
<rdar://problem/79651855>
Note You need to log in before you can comment on or make changes to this bug.