Bug 227278

Summary:

Message dropped when restoring webpages.

Product:

WebKit

Reporter:

Megan Gardner <megan_gardner>

Component:

New Bugs

Assignee:

Megan Gardner <megan_gardner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Megan Gardner 2021-06-22 22:02:21 PDT

Message dropped when restoring webpages.

Comment 1 Megan Gardner 2021-06-22 22:07:43 PDT

Created attachment 432018 [details]
Patch

Comment 2 Tim Horton 2021-06-22 22:12:57 PDT

Comment on attachment 432018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432018&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:615
>          setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden);
>      };

You could shove this block inline instead of in a local, now, if you wanted. But this is fine too.

Comment 3 Megan Gardner 2021-06-22 22:35:51 PDT

I liked it and left it on purpose ;P

Comment 4 EWS 2021-06-22 23:34:37 PDT

Committed r279166 (239063@main): <https://commits.webkit.org/239063@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432018 [details].

Comment 5 Radar WebKit Bug Importer 2021-06-22 23:35:17 PDT

<rdar://problem/79651855>