Bug 227269

Summary: [macOS] Suspend WebProcesses that are in the process cache
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kkinnunen, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2021-06-22 14:13:07 PDT
Suspend WebProcesses that are in the process cache on macOS to make sure they use no CPU.
Attachments
Patch (6.75 KB, patch)
2021-06-22 14:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.63 KB, patch)
2021-07-01 15:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2021-07-06 12:54 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.98 KB, patch)
2021-07-06 13:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-22 14:16:58 PDT
Created attachment 431993 [details] Patch
Geoffrey Garen
Comment 2 2021-06-22 14:41:52 PDT
Comment on attachment 431993 [details] Patch r=me
EWS
Comment 3 2021-06-22 16:48:41 PDT
Committed r279155 (239059@main): <https://commits.webkit.org/239059@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431993 [details].
Radar WebKit Bug Importer
Comment 4 2021-06-22 16:49:21 PDT
<rdar://problem/79639863>
Chris Dumez
Comment 5 2021-06-30 08:23:10 PDT
Reverted r279155 for reason: Caused a PLT5 regression Committed r279411 (239276@main): <https://commits.webkit.org/239276@main>
Chris Dumez
Comment 6 2021-07-01 14:55:52 PDT
I can reproduce the issue on PLT5 locally. I am investigating. 2 of the pages hang for an extended period of time of warm loads (but eventually recover). It looks like the cached process ends up exiting in this case and the load eventually happens in a fresh process. I don't see any crash report though.
Chris Dumez
Comment 7 2021-07-01 15:04:59 PDT
(In reply to Chris Dumez from comment #6) > I can reproduce the issue on PLT5 locally. I am investigating. 2 of the > pages hang for an extended period of time of warm loads (but eventually > recover). It looks like the cached process ends up exiting in this case and > the load eventually happens in a fresh process. I don't see any crash report > though. Oh, I think the pages that cause trouble are the ones with service workers. If I look at the logs, I see this logging right after we resume the cached process: com.apple.WebKit 2021-07-01 14:51:37.071485 -0700 ServiceWorker error 28186 com.apple.WebKit.WebContent.Development Failed to terminate service worker with identifier 1535, killing the service worker process And then the Cached WebProcess dies.
Chris Dumez
Comment 8 2021-07-01 15:54:42 PDT
Created attachment 432739 [details] Patch
Geoffrey Garen
Comment 9 2021-07-01 16:10:19 PDT
Comment on attachment 432739 [details] Patch r=me
EWS
Comment 10 2021-07-01 20:14:34 PDT
Committed r279495 (239347@main): <https://commits.webkit.org/239347@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432739 [details].
Chris Dumez
Comment 11 2021-07-06 09:00:28 PDT
Reverted r279495 for reason: Seems to have caused a ~2% PLT5 regression Committed r279583 (239414@main): <https://commits.webkit.org/239414@main>
Chris Dumez
Comment 12 2021-07-06 12:54:51 PDT
Created attachment 432962 [details] Patch
Chris Dumez
Comment 13 2021-07-06 12:57:43 PDT
(In reply to Chris Dumez from comment #12) > Created attachment 432962 [details] > Patch New iteration, I am currently evaluating its impact on PLT5.
Chris Dumez
Comment 14 2021-07-06 13:22:46 PDT
Created attachment 432966 [details] Patch
Chris Dumez
Comment 15 2021-07-07 08:17:30 PDT
Comment on attachment 432966 [details] Patch A/B bots say no PLT5 regression with this latest iteration.
Geoffrey Garen
Comment 16 2021-07-07 09:36:27 PDT
Comment on attachment 432966 [details] Patch r=me
EWS
Comment 17 2021-07-07 09:44:39 PDT
Committed r279644 (239457@main): <https://commits.webkit.org/239457@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432966 [details].
Note You need to log in before you can comment on or make changes to this bug.