Bug 227250

Summary: Not all uses of AudioToolbox framework use soft linking
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227381
https://bugs.webkit.org/show_bug.cgi?id=227435
Bug Depends on: 227208, 227434    
Bug Blocks: 227110    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Jean-Yves Avenard [:jya] 2021-06-22 03:30:55 PDT 
Noticed while working on bug 227205.

On iOS for some use of the AudioToolbox, soft-linking is used but not others.
Additionally, there are multiple definition of the macro to define some methods like AudioConverterNew where the macro to link it is used unnecessarily 4 times.
Comment 1 Radar WebKit Bug Importer 2021-06-22 03:31:17 PDT 
<rdar://problem/79606090>
Comment 2 Jean-Yves Avenard [:jya] 2021-06-22 04:14:25 PDT 
Created attachment 431956 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-06-22 05:16:04 PDT 
Depends on bug 227208 to build
Comment 4 Eric Carlson 2021-06-22 10:01:39 PDT 
Comment on attachment 431956 [details]
Patch

r=me once the bots are happy
Comment 5 Jean-Yves Avenard [:jya] 2021-06-23 08:22:39 PDT 
Created attachment 432043 [details]
Patch
Comment 6 Jean-Yves Avenard [:jya] 2021-06-23 08:29:46 PDT 
Created attachment 432047 [details]
Patch

rebase
Comment 7 Jean-Yves Avenard [:jya] 2021-06-23 16:13:10 PDT 
Created attachment 432102 [details]
Patch

fix compilation on iOS/tvOS
Comment 8 Jean-Yves Avenard [:jya] 2021-06-23 16:42:08 PDT 
Created attachment 432108 [details]
Patch

rebase
Comment 9 Jean-Yves Avenard [:jya] 2021-06-23 17:11:05 PDT 
Created attachment 432116 [details]
Patch

Fix iOS compilation
Comment 10 Jean-Yves Avenard [:jya] 2021-06-23 17:27:05 PDT 
Created attachment 432119 [details]
Patch

Fix tvOS compilation
Comment 11 Eric Carlson 2021-06-23 17:39:09 PDT 
Comment on attachment 432119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432119&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:39
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

This should be removed.

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:46
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

Ditto.
Comment 12 Jean-Yves Avenard [:jya] 2021-06-23 18:06:42 PDT 
Created attachment 432121 [details]
Patch

Apply comments
Comment 13 Jean-Yves Avenard [:jya] 2021-06-23 18:29:11 PDT 
Created attachment 432122 [details]
Patch

fix build #459
Comment 14 EWS 2021-06-23 19:20:51 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 15 Jean-Yves Avenard [:jya] 2021-06-23 19:25:48 PDT 
Created attachment 432127 [details]
Patch

Fix changelog
Comment 16 EWS 2021-06-23 21:13:14 PDT 
Committed r279208 (239094@main): <https://commits.webkit.org/239094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432127 [details].
Comment 17 Ryan Haddad 2021-06-25 10:18:45 PDT 
I reverted this in https://commits.webkit.org/239167@main because it broke the Windows build.
Comment 18 Jean-Yves Avenard [:jya] 2021-06-27 19:17:54 PDT 
Created attachment 432363 [details]
Patch

Re-ordered some definitions as they didn't exist on Windows
Comment 19 EWS 2021-06-27 20:30:24 PDT 
Committed r279322 (239198@main): <https://commits.webkit.org/239198@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432363 [details].
Comment 20 WebKit Commit Bot 2021-06-27 22:04:40 PDT 
Re-opened since this is blocked by bug 227434
Comment 21 Jean-Yves Avenard [:jya] 2021-06-27 22:29:27 PDT 
Created attachment 432365 [details]
Patch

Turned out, those non-existing symbols are in use on Windows
Comment 22 Jean-Yves Avenard [:jya] 2021-06-28 00:01:04 PDT 
Created attachment 432367 [details]
Patch
Comment 23 Jean-Yves Avenard [:jya] 2021-06-28 01:49:54 PDT 
Created attachment 432372 [details]
Patch
Comment 24 Jean-Yves Avenard [:jya] 2021-06-28 02:12:46 PDT 
Created attachment 432374 [details]
Patch
Comment 25 EWS 2021-06-28 05:29:48 PDT 
Committed r279335 (239204@main): <https://commits.webkit.org/239204@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432374 [details].