Bug 227230

Summary: Shrink sizeof(RegisteredEventListener)
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, ews-feeder: commit-queue-
Patch none

Yusuke Suzuki
Reported 2021-06-21 12:06:15 PDT
Shrink sizeof(RegisteredEventListener)
Attachments
Patch (2.31 KB, patch)
2021-06-21 12:07 PDT, Yusuke Suzuki 		ggaren: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.31 KB, patch)
2021-06-21 14:29 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-06-21 12:07:18 PDT
Created attachment 431892 [details] Patch
Chris Dumez
Comment 2 2021-06-21 12:11:20 PDT
Comment on attachment 431892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review > Source/WebCore/dom/RegisteredEventListener.h:68 > + bool m_useCapture : 1; do we really need the ": 1"?
Yusuke Suzuki
Comment 3 2021-06-21 12:18:10 PDT
Comment on attachment 431892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review >> Source/WebCore/dom/RegisteredEventListener.h:68 >> + bool m_useCapture : 1; > > do we really need the ": 1"? I prefer using bit fields for many bool flags since we can easily add more things while maintaining size.
Geoffrey Garen
Comment 4 2021-06-21 12:35:23 PDT
Comment on attachment 431892 [details] Patch r=me
Yusuke Suzuki
Comment 5 2021-06-21 14:29:05 PDT
Created attachment 431910 [details] Patch
Yusuke Suzuki
Comment 6 2021-06-22 08:31:15 PDT
Committed r279117 (239034@main): <https://commits.webkit.org/239034@main>
Radar WebKit Bug Importer
Comment 7 2021-06-22 08:32:16 PDT
<rdar://problem/79615813>
Yusuke Suzuki
Comment 8 2021-06-25 16:22:52 PDT
Use this commit to test webkitbot. Please ignore following messages.
Note You need to log in before you can comment on or make changes to this bug.