Bug 227230

Summary: Shrink sizeof(RegisteredEventListener)
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+, ews-feeder: commit-queue-
Patch none

Description Yusuke Suzuki 2021-06-21 12:06:15 PDT 
Shrink sizeof(RegisteredEventListener)
Comment 1 Yusuke Suzuki 2021-06-21 12:07:18 PDT 
Created attachment 431892 [details]
Patch
Comment 2 Chris Dumez 2021-06-21 12:11:20 PDT 
Comment on attachment 431892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review

> Source/WebCore/dom/RegisteredEventListener.h:68
> +    bool m_useCapture : 1;

do we really need the ": 1"?
Comment 3 Yusuke Suzuki 2021-06-21 12:18:10 PDT 
Comment on attachment 431892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431892&action=review

>> Source/WebCore/dom/RegisteredEventListener.h:68
>> +    bool m_useCapture : 1;
> 
> do we really need the ": 1"?

I prefer using bit fields for many bool flags since we can easily add more things while maintaining size.
Comment 4 Geoffrey Garen 2021-06-21 12:35:23 PDT 
Comment on attachment 431892 [details]
Patch

r=me
Comment 5 Yusuke Suzuki 2021-06-21 14:29:05 PDT 
Created attachment 431910 [details]
Patch
Comment 6 Yusuke Suzuki 2021-06-22 08:31:15 PDT 
Committed r279117 (239034@main): <https://commits.webkit.org/239034@main>
Comment 7 Radar WebKit Bug Importer 2021-06-22 08:32:16 PDT 
<rdar://problem/79615813>
Comment 8 Yusuke Suzuki 2021-06-25 16:22:52 PDT 
Use this commit to test webkitbot. Please ignore following messages.