Bug 227227

Summary: [Cocoa] iOS device steals BT headphones from other devices during silent playback
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227930
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch
ews-feeder: commit-queue-
Patch none

Description Jer Noble 2021-06-21 11:24:48 PDT 
[Cocoa] iPad steals AirPods from other devices during silent playback
Comment 1 Jer Noble 2021-06-21 11:26:23 PDT 
<rdar://78792479>
Comment 2 Jer Noble 2021-06-21 11:41:12 PDT 
Created attachment 431886 [details]
Patch
Comment 3 Jer Noble 2021-06-21 11:43:19 PDT 
Created attachment 431888 [details]
Patch
Comment 4 Eric Carlson 2021-06-21 12:31:35 PDT 
Comment on attachment 431888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431888&action=review

> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:100
> +static void setEligibleForSmartRouting(bool eligible)
> +{

Probably worth asserting if this is called on the main thread.
Comment 5 Jer Noble 2021-06-21 12:42:43 PDT 
Created attachment 431895 [details]
Patch for landing
Comment 6 Jer Noble 2021-06-21 13:19:33 PDT 
<rdar://67615678>
Comment 7 EWS 2021-06-22 09:17:55 PDT 
Committed r279119 (239036@main): <https://commits.webkit.org/239036@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431895 [details].
Comment 8 Jer Noble 2021-06-22 13:07:41 PDT 
Follow-up tvOS and Catalyst build fix: Committed r279138
Comment 9 Truitt Savell 2021-06-23 16:33:26 PDT 
it looks like the changes in https://trac.webkit.org/changeset/279119/webkit broke testing for iOS debug with 50+ timeouts and 40 API failures https://build.webkit.org/#/builders/59/builds/1679 I need to revert this unless its something simple.

Talked to Jer offline and he believes removing the Assert is the right thing to do.
Comment 10 Truitt Savell 2021-06-23 16:41:53 PDT 
Reopening to attach new patch.
Comment 11 Truitt Savell 2021-06-23 16:41:55 PDT 
Created attachment 432107 [details]
Patch
Comment 12 Truitt Savell 2021-06-23 16:49:08 PDT 
Created attachment 432110 [details]
Patch
Comment 13 EWS 2021-06-23 17:30:55 PDT 
Patch 432107 does not build
Comment 14 EWS 2021-06-23 17:45:09 PDT 
Committed r279200 (239087@main): <https://commits.webkit.org/239087@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432110 [details].