Bug 227227

Summary: [Cocoa] iOS device steals BT headphones from other devices during silent playback
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227930
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch
ews-feeder: commit-queue-
Patch none

Jer Noble
Reported 2021-06-21 11:24:48 PDT
[Cocoa] iPad steals AirPods from other devices during silent playback
Attachments
Patch (5.91 KB, patch)
2021-06-21 11:41 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.91 KB, patch)
2021-06-21 11:43 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.94 KB, patch)
2021-06-21 12:42 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2021-06-23 16:41 PDT, Truitt Savell 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2021-06-23 16:49 PDT, Truitt Savell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-06-21 11:26:23 PDT
<rdar://78792479>
Jer Noble
Comment 2 2021-06-21 11:41:12 PDT
Created attachment 431886 [details] Patch
Jer Noble
Comment 3 2021-06-21 11:43:19 PDT
Created attachment 431888 [details] Patch
Eric Carlson
Comment 4 2021-06-21 12:31:35 PDT
Comment on attachment 431888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431888&action=review > Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:100 > +static void setEligibleForSmartRouting(bool eligible) > +{ Probably worth asserting if this is called on the main thread.
Jer Noble
Comment 5 2021-06-21 12:42:43 PDT
Created attachment 431895 [details] Patch for landing
Jer Noble
Comment 6 2021-06-21 13:19:33 PDT
<rdar://67615678>
EWS
Comment 7 2021-06-22 09:17:55 PDT
Committed r279119 (239036@main): <https://commits.webkit.org/239036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431895 [details].
Jer Noble
Comment 8 2021-06-22 13:07:41 PDT
Follow-up tvOS and Catalyst build fix: Committed r279138
Truitt Savell
Comment 9 2021-06-23 16:33:26 PDT
it looks like the changes in https://trac.webkit.org/changeset/279119/webkit broke testing for iOS debug with 50+ timeouts and 40 API failures https://build.webkit.org/#/builders/59/builds/1679 I need to revert this unless its something simple. Talked to Jer offline and he believes removing the Assert is the right thing to do.
Truitt Savell
Comment 10 2021-06-23 16:41:53 PDT
Reopening to attach new patch.
Truitt Savell
Comment 11 2021-06-23 16:41:55 PDT
Created attachment 432107 [details] Patch
Truitt Savell
Comment 12 2021-06-23 16:49:08 PDT
Created attachment 432110 [details] Patch
EWS
Comment 13 2021-06-23 17:30:55 PDT
Patch 432107 does not build
EWS
Comment 14 2021-06-23 17:45:09 PDT
Committed r279200 (239087@main): <https://commits.webkit.org/239087@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432110 [details].
Note You need to log in before you can comment on or make changes to this bug.