Bug 227215
| Summary: | Web Inspector: Styles: Autocomplete list should appear when pressing Arrow Down | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Razvan Caliman <rcaliman> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, nvasilyev, pangle, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Razvan Caliman
A common UI pattern is for a hidden list of suggestions for an input field to appear when pressing the Arrow Down key.
In the Styles panel, this is replaced by the keyboard shortcut Ctrl+Space ...:
`/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:293`
```
if (this._controlSpaceKeyboardShortcut.matchesEvent(event)) {
event.stop();
if (this._suggestionsView.visible)
this._suggestionsView.hide();
else {
const forceCompletions = true;
this._updateCompletions(forceCompletions);
}
return;
}
```
... likely because it interacts with the behavior of incrementing/decrementing numeric values when holding Arrow Up/Down. See bug 227214.
---
When the typing caret is not overlapping a numeric value, pressing Arrow Down in an editable text field should present the list of completion suggestions if there are any.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patrick Angle
Another thing we need to consider here is multi-line CSS values, where the Up/down arrow keys should have a different meaning. grid-template-areas’ being one that comes to mind. In that case we can’t really provide a completion anyways, but we should make sure we don’t break those cases where you want to move the caret to the next line.
Nikita Vasilyev
(In reply to Patrick Angle from comment #1)
> Another thing we need to consider here is multi-line CSS values, where the
> Up/down arrow keys should have a different meaning. grid-template-areas’
> being one that comes to mind. In that case we can’t really provide a
> completion anyways, but we should make sure we don’t break those cases where
> you want to move the caret to the next line.
I was about to make the same example 😂
Even `background` value can span several line, and we do provide completions there. I don't think we should attempt to provide completions in multiline values on ArrowDown.
Radar WebKit Bug Importer
<rdar://problem/79864731>