| Summary: | [Cocoa] Migrate WebRTC UDP socket handling to NW API | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer, youennf | ||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=233752 | ||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||
|
Description
youenn fablet
2021-06-21 04:33:26 PDT
Created attachment 431847 [details]
Patch
Created attachment 431849 [details]
Patch
Created attachment 431867 [details]
Patch
Created attachment 431880 [details]
Patch
Created attachment 431887 [details]
Patch
Created attachment 431951 [details]
Patch
Created attachment 431954 [details]
Patch
Created attachment 431958 [details]
Patch
iOS test failure is probably related to change in the timing, but I do not think this is a regression per se. Comment on attachment 431958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431958&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h:2 > + * Copyright (C) 2020 Apple Inc. All rights reserved. Nit: should this be 2021? > Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:2 > + * Copyright (C) 2020 Apple Inc. All rights reserved. Ditto > Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:74 > + if (error) > + return; Is it worth logging this error? Created attachment 432493 [details]
Patch for landing
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Created attachment 432570 [details]
Patch for landing
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Created attachment 432571 [details]
Patch for landing
Committed r279405 (239270@main): <https://commits.webkit.org/239270@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432571 [details]. t looks like the changes in https://trac.webkit.org/changeset/279405/webkit broke 50+ webrtc tests for mac debug https://build.webkit.org/#/builders/23/builds/2608 We should revert this if it is not a quick fix Reverted r279405 for reason: Casued 50+ webrtc crashes on Big Sur Debug Committed r279432 (239291@main): <https://commits.webkit.org/239291@main> Crash seems to be related to use of nw_endpoint_get_hostname which is not behaving the same in BigSur and Monterey. I will check endpoint type for extra safety. Created attachment 432667 [details]
Patch for landing
Committed r279461 (239317@main): <https://commits.webkit.org/239317@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432667 [details]. Reopening to attach new patch. Created attachment 432687 [details]
Patch
Created attachment 432691 [details]
Patch
Committed r279464 (239320@main): <https://commits.webkit.org/239320@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432691 [details]. |