Bug 227188 – Add a new pattern to instruction selector to utilize SMADDL supported by ARM64

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Yijia Huang]

...

[Yijia Huang]

Created attachment 431889 [details]
Patch

[Yijia Huang]

Created attachment 431891 [details]
Patch

[Saam Barati]

Comment on attachment 431891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431891&action=review

Nice. r=me

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2548
>              Air::Opcode multiplyAddOpcode = tryOpcodeForType(MultiplyAdd32, MultiplyAdd64, m_value->type());

maybe worth an assert the multiple add sign extend is available on the same platforms as this, otherwise we wouldn't want it inside this if statement.

Maybe: ASSERT(isValidForm(MultiplyAdd64, Arg::Tmp, Arg::Tmp, Arg::Tmp, Arg::Tmp) == isValidForm(MultiplyAddSignExtend32, Arg::Tmp, Arg::Tmp, Arg::Tmp, Arg::Tmp))

[Yijia Huang]

Created attachment 431938 [details]
Patch

[Yijia Huang]

Created attachment 431972 [details]
Patch

[Yijia Huang]

(In reply to Saam Barati from comment #3)
> Comment on attachment 431891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431891&action=review
> 
> Nice. r=me
> 
> > Source/JavaScriptCore/b3/B3LowerToAir.cpp:2548
> >              Air::Opcode multiplyAddOpcode = tryOpcodeForType(MultiplyAdd32, MultiplyAdd64, m_value->type());
> 
> maybe worth an assert the multiple add sign extend is available on the same
> platforms as this, otherwise we wouldn't want it inside this if statement.
> 
> Maybe: ASSERT(isValidForm(MultiplyAdd64, Arg::Tmp, Arg::Tmp, Arg::Tmp,
> Arg::Tmp) == isValidForm(MultiplyAddSignExtend32, Arg::Tmp, Arg::Tmp,
> Arg::Tmp, Arg::Tmp))

Updated, thanks for the review.

[Yijia Huang]

Created attachment 431974 [details]
Patch

[EWS]

Committed r279134 (239048@main): <https://commits.webkit.org/239048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431974 [details].