Bug 227167

Summary: [css-grid] Use correct block-size to resolve min-content
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zsun
Reported 2021-06-18 06:12:12 PDT
The following WPT test fails - css/css-grid/grid-items/grid-item-inline-contribution-001.html
Attachments
Patch (4.87 KB, patch)
2021-06-18 06:51 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2021-06-21 07:05 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2021-07-14 06:41 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2021-07-19 02:32 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2021-06-18 06:51:34 PDT
Created attachment 431773 [details] Patch
EWS Watchlist
Comment 2 2021-06-18 06:52:41 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
zsun
Comment 3 2021-06-21 07:05:36 PDT
Created attachment 431857 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-06-25 06:13:16 PDT
<rdar://problem/79775068>
Javier Fernandez
Comment 5 2021-06-28 13:04:11 PDT
Comment on attachment 431857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431857&action=review You are adding a TestExpectation Fail entry with the bug this patch tries to fix. > LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-001-expected.xht:5 > + <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> Encoding issue.
zsun
Comment 6 2021-07-14 06:41:55 PDT
Created attachment 433498 [details] Patch
Javier Fernandez
Comment 7 2021-07-17 03:00:54 PDT
Comment on attachment 433498 [details] Patch r=me
EWS
Comment 8 2021-07-19 01:38:52 PDT
Tools/Scripts/svn-apply failed to apply attachment 433498 [details] to trunk. Please resolve the conflicts and upload a new patch.
zsun
Comment 9 2021-07-19 02:32:26 PDT
Created attachment 433780 [details] Patch
EWS
Comment 10 2021-07-19 06:55:31 PDT
Committed r280023 (239765@main): <https://commits.webkit.org/239765@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433780 [details].
Simon Fraser (smfr)
Comment 11 2022-07-12 11:58:53 PDT
Comment on attachment 433780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433780&action=review > Source/WebCore/rendering/RenderReplaced.cpp:122 > + if (replacedContentRect() != oldContentRect) > + setPreferredLogicalWidthsDirty(true); This doesn't seem right at all. Why is a CSS Grid fix in RenderReplaced? Why is this marking layout dirty at the end of layout? Why does replacedContentRect (which is about painting) have anything to do with layout?
zsun
Comment 12 2022-07-13 00:54:38 PDT
Any chance to revert this change? Thank you!
Note You need to log in before you can comment on or make changes to this bug.