Bug 227167

Summary: [css-grid] Use correct block-size to resolve min-content
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description zsun 2021-06-18 06:12:12 PDT 
The following WPT test fails -

css/css-grid/grid-items/grid-item-inline-contribution-001.html
Comment 1 zsun 2021-06-18 06:51:34 PDT 
Created attachment 431773 [details]
Patch
Comment 2 EWS Watchlist 2021-06-18 06:52:41 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 zsun 2021-06-21 07:05:36 PDT 
Created attachment 431857 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-06-25 06:13:16 PDT 
<rdar://problem/79775068>
Comment 5 Javier Fernandez 2021-06-28 13:04:11 PDT 
Comment on attachment 431857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431857&action=review

You are adding a TestExpectation Fail entry with the bug this patch tries to fix.

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-inline-contribution-001-expected.xht:5
> +  <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" />

Encoding issue.
Comment 6 zsun 2021-07-14 06:41:55 PDT 
Created attachment 433498 [details]
Patch
Comment 7 Javier Fernandez 2021-07-17 03:00:54 PDT 
Comment on attachment 433498 [details]
Patch

r=me
Comment 8 EWS 2021-07-19 01:38:52 PDT 
Tools/Scripts/svn-apply failed to apply attachment 433498 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 9 zsun 2021-07-19 02:32:26 PDT 
Created attachment 433780 [details]
Patch
Comment 10 EWS 2021-07-19 06:55:31 PDT 
Committed r280023 (239765@main): <https://commits.webkit.org/239765@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433780 [details].
Comment 11 Simon Fraser (smfr) 2022-07-12 11:58:53 PDT 
Comment on attachment 433780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433780&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:122
> +    if (replacedContentRect() != oldContentRect)
> +        setPreferredLogicalWidthsDirty(true);

This doesn't seem right at all. Why is a CSS Grid fix in RenderReplaced? Why is this marking layout dirty at the end of layout? Why does replacedContentRect (which is about painting) have anything to do with layout?
Comment 12 zsun 2022-07-13 00:54:38 PDT 
Any chance to revert this change? Thank you!