Bug 227154

Summary:

Add assertion in RunLoop::dispatch

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, sihui_liu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Alex Christensen 2021-06-17 16:52:08 PDT

Add assertion in RunLoop::dispatch

Comment 1 Alex Christensen 2021-06-17 16:53:37 PDT

Created attachment 431741 [details]
Patch

Comment 2 Geoffrey Garen 2021-06-17 16:55:53 PDT

Comment on attachment 431741 [details]
Patch

r=me

Comment 3 Alex Christensen 2021-06-17 17:01:00 PDT

http://trac.webkit.org/r279025

Comment 4 Radar WebKit Bug Importer 2021-06-17 17:02:29 PDT

<rdar://problem/79477948>

Comment 5 Chris Dumez 2021-06-17 17:03:14 PDT

I bet Sihui just fixed it via:
commit 9c3f87df21fba60bd607cb2[3a70b6fad5ac56926
Author: sihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu Jun 10 23:55:52 2021 +0000

    Regression(r278449): add null check for completionHandler in WebIDBServer::close
    https://bugs.webkit.org/show_bug.cgi?id=226900
    rdar://79160392
    
    Reviewed by Chris Dumez.
    
    * NetworkProcess/IndexedDB/WebIDBServer.cpp:
    (WebKit::WebIDBServer::close):


And your assertion wouldn't have caught it I believe?