Bug 22714

Summary: Clean up some autotools warnings
Product: WebKit Reporter: Daniel Macks <dmacks>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Macintosh   
OS: Mac OS X 10.4   
Attachments:
Description Flags
Add autotools flags as requested by current autotools versions none

Description Daniel Macks 2008-12-06 13:11:22 PST
Building r39007 on OS X 10.4 with autoconf-2.63 automake-1.10.2 libtool-2.2.4, autogen.sh whines:

libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.

So okay, let's do that.
Comment 1 Daniel Macks 2008-12-06 13:30:58 PST
Created attachment 25820 [details]
Add autotools flags as requested by current autotools versions

With this patch, autogen gives:

>libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
>libtoolize: linking file `m4/libtool.m4'
>libtoolize: linking file `m4/ltoptions.m4'
>libtoolize: linking file `m4/ltsugar.m4'
>libtoolize: linking file `m4/ltversion.m4'
>libtoolize: linking file `m4/lt~obsolete.m4'
>libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.

Looks like libtool is doing a simple grep in Makefile.am, doesn't know WebKit uses GNUmakefile.am instead. Why *does* it use GNUmakefile instead of Makefile?
Comment 2 Mark Rowe (bdash) 2008-12-06 14:57:18 PST
(In reply to comment #1)
> Looks like libtool is doing a simple grep in Makefile.am, doesn't know WebKit
> uses GNUmakefile.am instead. Why *does* it use GNUmakefile instead of Makefile?

Because Makefile is used for other purposes.
Comment 3 Darin Adler 2008-12-10 14:48:39 PST
Comment on attachment 25820 [details]
Add autotools flags as requested by current autotools versions

r=me

tabs in ChangeLog
Comment 4 Holger Freyther 2008-12-11 16:32:47 PST
Could you please set a valid email address in future patches?
Comment 5 Holger Freyther 2008-12-11 16:38:06 PST
Landed in r39222.
Comment 6 Holger Freyther 2008-12-12 08:04:15 PST
Yes, autotools complains about not adding m4. But this directory does not even exist and is breaking the build for others... I will back this patch out and we can look for another solution.
Comment 7 Mark Rowe (bdash) 2009-01-12 23:33:22 PST
Comment on attachment 25820 [details]
Add autotools flags as requested by current autotools versions

Clearing review flag since it appears that this patch was rolled out.
Comment 8 Daniel Macks 2009-01-13 00:28:10 PST
Experimenting further, this patch (nor any similar variant I tried) doesn't fully clear the warnings reliably. I talked to a libtool developer who said they only recently became aware of gnumakefile.am as an alternative to makefile.am. I'm (now) not surprised that there are warnings and that trying to fix them creates other problems at this time:(
Comment 9 Martin Robinson 2014-03-25 15:17:33 PDT
Autotools is gone now.