Bug 227102

Summary:

[Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Web Template Framework

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pvollan, rniwa, webkit-bug-importer

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Fujii Hironori 2021-06-16 17:06:53 PDT

[Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing

https://build.webkit.org/#/builders/50/builds/1808

worker/0 TestWTF.WTF_WeakPtr.WeakHashMapAmortizedCleanup Crashed
worker/0 TestWTF.WTF_WeakPtr.WeakHashMapIterators Crashed

Those tests were added by r278803 (238760@main, Bug 226872).

Comment 1 Fujii Hironori 2021-06-16 17:07:20 PDT

Callstack:

> ntdll.dll!RtlReportCriticalFailure()	Unknown
> ntdll.dll!RtlpHeapHandleError()	Unknown
> ntdll.dll!RtlpHpHeapHandleError()	Unknown
> ntdll.dll!RtlpLogHeapFailure()	Unknown
> ntdll.dll!RtlpFreeHeapInternal()	Unknown
> ntdll.dll!RtlFreeHeap()	Unknown
> ucrtbase.dll!00007ffd3a6df05b()	Unknown
> WTF.dll!WTF::fastFree(void * p) Line 260	C++
> TestWTFLib.dll!TestWebKitAPI::Base::operator delete(void * p) Line 55	C++
> [External Code]	
> TestWTFLib.dll!TestWebKitAPI::WTF_WeakPtr_WeakHashMapIterators_Test::TestBody() Line 1455	C++
> TestWTFLib.dll!testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test,void>(testing::Test * object, void(testing::Test::*)() method, const char * location) Line 2592	C++
> TestWTFLib.dll!testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>(testing::Test * object, void(testing::Test::*)() method, const char * location) Line 2662	C++
> TestWTFLib.dll!testing::Test::Run() Line 2689	C++
> TestWTFLib.dll!testing::TestInfo::Run() Line 2864	C++
> TestWTFLib.dll!testing::TestSuite::Run() Line 3016	C++
> TestWTFLib.dll!testing::internal::UnitTestImpl::RunAllTests() Line 5852	C++
> TestWTFLib.dll!testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>(testing::internal::UnitTestImpl * object, bool(testing::internal::UnitTestImpl::*)() method, const char * location) Line 2592	C++
> TestWTFLib.dll!testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>(testing::internal::UnitTestImpl * object, bool(testing::internal::UnitTestImpl::*)() method, const char * location) Line 2662	C++
> TestWTFLib.dll!testing::UnitTest::Run() Line 5434	C++
> TestWTFLib.dll!RUN_ALL_TESTS() Line 2472	C++
> TestWTFLib.dll!TestWebKitAPI::TestsController::run(int argc, char * * argv) Line 90	C++
> TestWTFLib.dll!main(int argc, char * * argv) Line 41	C++
> TestWTFLib.dll!dllLauncherEntryPoint(int argc, char * * argv) Line 49	C++
> TestWTF.exe!main(int argc, const char * * argv) Line 223	C++
> [External Code]

Comment 2 Fujii Hironori 2021-06-16 17:56:20 PDT

Created attachment 431627 [details]
Patch

Comment 3 Ryosuke Niwa 2021-06-16 21:28:29 PDT

Comment on attachment 431627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431627&action=review

> Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:59
> +    virtual ~Base() { }

Oh, makes sense. Do use ~Base() = default; though.

Comment 4 Fujii Hironori 2021-06-16 21:51:48 PDT

Created attachment 431632 [details]
Patch for landing

Comment 5 Fujii Hironori 2021-06-17 00:01:13 PDT

Comment on attachment 431632 [details]
Patch for landing

Clearing flags on attachment: 431632

Committed r278976 (238902@main): <https://commits.webkit.org/238902@main>

Comment 6 Fujii Hironori 2021-06-17 00:01:17 PDT

All reviewed patches have been landed.  Closing bug.