Bug 227090

Summary: [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Web Template FrameworkAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, don.olmstead, ews-watchlist, mark.lam, pvollan, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Description Fujii Hironori 2021-06-16 13:19:54 PDT
[Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing

PS C:\home\webkit\gb> .\WebKitBuild\Debug\bin64\TestWTF.exe --gtest_filter=WTF.ParseInteger*
**FAIL** WTF.ParseInteger

..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:43
Expected equality of these values:
  -2147483647 - 1
    Which is: -2147483648
  parseInteger<int>("-2147483648")
    Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC>

**FAIL** WTF.ParseIntegerAllowingTrailingJunk

..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:70
Expected equality of these values:
  -2147483647 - 1
    Which is: -2147483648
  parseIntegerAllowingTrailingJunk<int>("-2147483648")
    Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC>
Comment 1 Fujii Hironori 2021-06-16 13:51:52 PDT
Created attachment 431596 [details]
WIP patch
Comment 2 Fujii Hironori 2021-06-16 14:34:45 PDT
Created attachment 431604 [details]
Patch
Comment 3 Yusuke Suzuki 2021-06-17 17:53:28 PDT
Comment on attachment 431604 [details]
Patch

r=me
Comment 4 EWS 2021-06-17 18:28:02 PDT
Committed r279027 (238947@main): <https://commits.webkit.org/238947@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431604 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-17 18:29:30 PDT
<rdar://problem/79481414>