Bug 227090

Summary: [Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web Template FrameworkAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, don.olmstead, ews-watchlist, mark.lam, pvollan, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch none

Fujii Hironori
Reported 2021-06-16 13:19:54 PDT
[Win] WTF.ParseInteger and WTF.ParseIntegerAllowingTrailingJunk are failing PS C:\home\webkit\gb> .\WebKitBuild\Debug\bin64\TestWTF.exe --gtest_filter=WTF.ParseInteger* **FAIL** WTF.ParseInteger ..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:43 Expected equality of these values: -2147483647 - 1 Which is: -2147483648 parseInteger<int>("-2147483648") Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC> **FAIL** WTF.ParseIntegerAllowingTrailingJunk ..\..\Tools\TestWebKitAPI\Tests\WTF\StringToIntegerConversion.cpp:70 Expected equality of these values: -2147483647 - 1 Which is: -2147483648 parseIntegerAllowingTrailingJunk<int>("-2147483648") Which is: 8-byte object <CC-CC CC-CC 00-CC CC-CC>
Attachments
WIP patch (697 bytes, patch)
2021-06-16 13:51 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2021-06-16 14:34 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-06-16 13:51:52 PDT
Created attachment 431596 [details] WIP patch
Fujii Hironori
Comment 2 2021-06-16 14:34:45 PDT
Created attachment 431604 [details] Patch
Yusuke Suzuki
Comment 3 2021-06-17 17:53:28 PDT
Comment on attachment 431604 [details] Patch r=me
EWS
Comment 4 2021-06-17 18:28:02 PDT
Committed r279027 (238947@main): <https://commits.webkit.org/238947@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431604 [details].
Radar WebKit Bug Importer
Comment 5 2021-06-17 18:29:30 PDT
<rdar://problem/79481414>
Note You need to log in before you can comment on or make changes to this bug.