Bug 227076

Summary: Passkeys don't work in Simulator
Product: WebKit Reporter: Garrett Davidson <garrett_davidson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, jiewen_tan, katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Garrett Davidson
Reported 2021-06-16 09:29:00 PDT
Passkeys don't work in Simulator
Attachments
Patch (2.02 KB, patch)
2021-06-16 09:30 PDT, Garrett Davidson 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2021-06-16 15:09 PDT, Garrett Davidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Garrett Davidson
Comment 1 2021-06-16 09:30:28 PDT
Created attachment 431554 [details] Patch
Garrett Davidson
Comment 2 2021-06-16 09:30:30 PDT
<rdar://problem/79366832>
Kate Cheney
Comment 3 2021-06-16 14:24:00 PDT
Comment on attachment 431554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431554&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:156 > +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR I am not familiar with TARGET_OS_SIMULATOR, I see PLATFORM(IOS_FAMILY_SIMULATOR) used more often. Is there a reason you chose this instead?
Brent Fulgham
Comment 4 2021-06-16 14:30:12 PDT
Comment on attachment 431554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431554&action=review r- to change the macro to PLATFORM(IOS_FAMILY_SIMULATOR), but otherwise looks great. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:156 >> +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR > > I am not familiar with TARGET_OS_SIMULATOR, I see PLATFORM(IOS_FAMILY_SIMULATOR) used more often. Is there a reason you chose this instead? Right -- we don't use these TARGET macros in WebKit. We have PLATFORM macros that serve this purpose (and handle the defined/not defined state properly). As Kate suggests, you just want: #if PLATFORM(IOS_FAMILY_SIMULATOR)
Garrett Davidson
Comment 5 2021-06-16 15:09:11 PDT
Created attachment 431609 [details] Patch
Brent Fulgham
Comment 6 2021-06-16 15:12:19 PDT
Comment on attachment 431609 [details] Patch r=me
EWS
Comment 7 2021-06-16 20:45:25 PDT
Committed r278973 (238899@main): <https://commits.webkit.org/238899@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431609 [details].
Note You need to log in before you can comment on or make changes to this bug.