Bug 227053
| Summary: | [GLIB] REGRESSION(r277896): fast/canvas/canvas-imageSmoothingEnabled.html and fast/canvas/canvas-imageSmoothingQuality.html are failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | fujii.hironori |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=225952 | ||
Diego Pino
r277896 change imageSmoothingQuality default value to 'Low' for all platforms, since that's how defined in the specification.
That change made 2 tests start failing:
fast/canvas/canvas-imageSmoothingEnabled.html [ Failure ]
fast/canvas/canvas-imageSmoothingQuality.html [ Failure ]
--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingEnabled-actual.txt
@@ -19,9 +19,9 @@
PASS left_of_center_pixel.data[1] is 0
PASS left_of_center_pixel.data[2] is 0
Test that the image is smoothed when imageSmoothingEnabled is set to true.
-PASS left_of_center_pixel.data[0] !== 0 is true
-PASS left_of_center_pixel.data[1] !== 0 is true
-PASS left_of_center_pixel.data[2] !== 0 is true
+FAIL left_of_center_pixel.data[0] !== 0 should be true. Was false.
+FAIL left_of_center_pixel.data[1] !== 0 should be true. Was false.
+FAIL left_of_center_pixel.data[2] !== 0 should be true. Was false.
Test that restoring actually changes smoothing and not just the attribute value. We are restoring to a point where imageSmoothingEnabled is set to false.
PASS left_of_center_pixel.data[0] is 0
PASS left_of_center_pixel.data[1] is 0
--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingQuality-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/canvas-imageSmoothingQuality-actual.txt
@@ -8,14 +8,14 @@
PASS mediumContext.imageSmoothingQuality is 'medium'
PASS highContext.imageSmoothingQuality is 'high'
-PASS lowData is not mediumData
+FAIL lowData should not be {"0":0,"1":0,"2":0,"3":128}.
PASS mediumData is not highData
PASS lowData is not highData
PASS sampleAlpha(lowData) is >= sampleAlpha(mediumData)
PASS sampleAlpha(mediumData) is >= sampleAlpha(highData)
-FAIL defaultContext.imageSmoothingQuality should be low. Was medium.
+PASS defaultContext.imageSmoothingQuality is 'low'
PASS highContext.imageSmoothingEnabled = false; highContext.imageSmoothingQuality is 'high'
PASS highContext.imageSmoothingQuality = 'medium'; highContext.imageSmoothingQuality is 'medium'
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Cairo based ports pass the test after 270586@main (bug#264605).
Expected to fail, but passed: (2)
fast/canvas/canvas-imageSmoothingEnabled.html
fast/canvas/canvas-imageSmoothingQuality.html
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html&test=fast%2Fcanvas%2Fcanvas-imageSmoothingEnabled.html
*** This bug has been marked as a duplicate of bug 264605 ***