Bug 227045

Summary:

Migrate App Privacy Report code from WebKitAdditions

Product:

WebKit

Reporter:

Kate Cheney <katherine_cheney>

Component:

New Bugs

Assignee:

Kate Cheney <katherine_cheney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, bfulgham, cdumez, cgarcia, cmarcelo, ews-watchlist, japhet, mkwst, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch for landing	none
Patch	none

Kate Cheney

Reported 2021-06-15 13:34:42 PDT

Migrate App Privacy Report code from WebKitAdditions

Attachments
Patch (253.75 KB, patch) 2021-06-15 13:43 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch (21.98 KB, patch) 2021-06-15 18:50 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch (21.84 KB, patch) 2021-06-16 16:35 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch (21.84 KB, patch) 2021-06-17 11:01 PDT, Kate Cheney	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (21.96 KB, patch) 2021-06-17 11:56 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch (24.12 KB, patch) 2021-06-21 09:41 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch for landing (21.98 KB, patch) 2021-06-21 13:28 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Patch (22.52 KB, patch) 2021-06-23 10:43 PDT, Kate Cheney	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Kate Cheney

Comment 1 2021-06-15 13:43:34 PDT

Created attachment 431477 [details] Patch

Chris Dumez

Comment 2 2021-06-15 13:51:07 PDT

Comment on attachment 431477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431477&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:341 > NSURLRequest *nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody); Seems you should address the FIXME above now. > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:344 > + NSMutableURLRequest *mutableRequest = [[nsRequest mutableCopy] autorelease]; Let's avoid using autorelease if possible.

Kate Cheney

Comment 3 2021-06-15 18:50:26 PDT

Created attachment 431509 [details] Patch

Kate Cheney

Comment 4 2021-06-15 18:51:04 PDT

I took out the renaming, and just left this as a migration patch for simplicity.

Kate Cheney

Comment 5 2021-06-16 16:35:24 PDT

Created attachment 431621 [details] Patch

Alex Christensen

Comment 6 2021-06-17 10:07:31 PDT

Comment on attachment 431621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431621&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:60 > +static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest * _Nonnull); Remove _Nonnull

Kate Cheney

Comment 7 2021-06-17 11:01:17 PDT

Created attachment 431691 [details] Patch

Kate Cheney

Comment 8 2021-06-17 11:56:09 PDT

Created attachment 431696 [details] Patch

Kate Cheney

Comment 9 2021-06-21 09:41:10 PDT

Created attachment 431871 [details] Patch

Kate Cheney

Comment 10 2021-06-21 09:41:58 PDT

forgot to unskip tests for open source in the latest patch. Will wait for EWS before landing.

Kate Cheney

Comment 11 2021-06-21 13:28:51 PDT

Created attachment 431902 [details] Patch for landing

Kate Cheney

Comment 12 2021-06-21 13:29:12 PDT

Never mind, EWS doesn't support these layout tests yet, keeping these skipped in open source. Local runs confirm all tests are passing.

EWS

Comment 13 2021-06-21 14:25:52 PDT

Committed r279083 (239002@main): <https://commits.webkit.org/239002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431902 [details].

Radar WebKit Bug Importer

Comment 14 2021-06-21 14:26:41 PDT Comment hidden (obsolete)

<rdar://problem/79580561>

Kate Cheney

Comment 15 2021-06-21 14:29:17 PDT

The correct radar is rdar://74333287

Truitt Savell

Comment 16 2021-06-22 09:45:06 PDT

Reverted r279083 for reason: Broke Mac Builds Committed r279120 (239037@main): <https://commits.webkit.org/239037@main>

Kate Cheney

Comment 17 2021-06-23 10:43:41 PDT

Created attachment 432071 [details] Patch

Kate Cheney

Comment 18 2021-06-23 11:48:44 PDT

(In reply to Kate Cheney from comment #17) > Created attachment 432071 [details] > Patch Checks for #if ENABLE(APP_PRIVACY_REPORT) && HAVE(SYMPTOMS_FRAMEWORK) will avoid breaking the build again. Tested locally that everything is building with no errors.

EWS

Comment 19 2021-06-23 13:27:21 PDT

Committed r279184 (239079@main): <https://commits.webkit.org/239079@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432071 [details].

Note You need to log in before you can comment on or make changes to this bug.