Bug 227038

Summary: Very noisy logging on Youtube: (libvpx_vp9_decoder.cc:226): Failed to parse VP9 header from key-frame.
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: eric.carlson, jean-yves.avenard, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Chris Dumez 2021-06-15 11:57:41 PDT
Watch a video on Youtube with a debug build and notice this logging:
(libvpx_vp9_decoder.cc:226): Failed to parse VP9 header from key-frame.

printed out many times a second. It is super noisy and potentially indicative of something wrong with our logic (even though the video is playing fine) so I am filing a bug.
Comment 1 Chris Dumez 2021-06-15 12:01:09 PDT
Eric says:
"""
We’re probably setting the key-frame flag when we shouldn’t before calling the codec
in decodeVP9DecoderFrameFromContiguousBlock()
"""

Code shows:
```
    // We set those values as VP9DecoderImpl checks for getting a full key frame as first frame.
    image._frameType = VideoFrameType::kVideoFrameKey;
    auto error = decoder.m_instance->Decode(image, false, 0);
```

We're indeed always setting the frame type to kVideoFrameKey.
Comment 2 Radar WebKit Bug Importer 2021-06-22 11:58:21 PDT
<rdar://problem/79626481>