Bug 227023

Summary: [GLIB] Pass a GTlsCertificate to soup_server_new()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+, ews-feeder: commit-queue-

Description Carlos Garcia Campos 2021-06-15 05:24:15 PDT
Instead of using soup_server_set_ssl_cert_file() that will be removed from libsoup soon.
Comment 1 Carlos Garcia Campos 2021-06-15 05:25:57 PDT
Created attachment 431425 [details]
Patch
Comment 2 Michael Catanzaro 2021-06-15 05:38:51 PDT
Comment on attachment 431425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431425&action=review

> Tools/TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:40
> +        certificate = adoptGRef(g_tls_certificate_new_from_files(sslCertificateFile.get(), sslKeyFile.get(), nullptr));

Bonus points if you pass an error parameter and g_assert_no_error() before the g_assert_nonnull(). That will give us a better error message in the unlikely event that it ever starts to fail in the future.
Comment 3 Carlos Garcia Campos 2021-06-17 01:38:57 PDT
Committed r278977 (238903@main): <https://commits.webkit.org/238903@main>
Comment 4 Radar WebKit Bug Importer 2021-06-17 01:39:26 PDT
<rdar://problem/79439185>