Bug 227023

Summary: [GLIB] Pass a GTlsCertificate to soup_server_new()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+, ews-feeder: commit-queue-

Carlos Garcia Campos
Reported 2021-06-15 05:24:15 PDT
Instead of using soup_server_set_ssl_cert_file() that will be removed from libsoup soon.
Attachments
Patch (2.04 KB, patch)
2021-06-15 05:25 PDT, Carlos Garcia Campos 		mcatanzaro: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-06-15 05:25:57 PDT
Created attachment 431425 [details] Patch
Michael Catanzaro
Comment 2 2021-06-15 05:38:51 PDT
Comment on attachment 431425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431425&action=review > Tools/TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:40 > + certificate = adoptGRef(g_tls_certificate_new_from_files(sslCertificateFile.get(), sslKeyFile.get(), nullptr)); Bonus points if you pass an error parameter and g_assert_no_error() before the g_assert_nonnull(). That will give us a better error message in the unlikely event that it ever starts to fail in the future.
Carlos Garcia Campos
Comment 3 2021-06-17 01:38:57 PDT
Committed r278977 (238903@main): <https://commits.webkit.org/238903@main>
Radar WebKit Bug Importer
Comment 4 2021-06-17 01:39:26 PDT
<rdar://problem/79439185>
Note You need to log in before you can comment on or make changes to this bug.