Bug 227015 – GraphicsContext::apply{Fill,Stroke}Pattern needs to do nothing if there is no fill/stroke pattern set

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

GraphicsContext::apply{Fill,Stroke}Pattern needs to do nothing if there is no fill/stroke pattern set

[Myles C. Maxfield]

Created attachment 431406 [details]
Patch

[EWS]

Committed r278885 (238827@main): <https://commits.webkit.org/238827@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431406 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79352245>

[Said Abou-Hallawa]

Comment on attachment 431406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431406&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:547
> +    if (!m_state.strokePattern)
> +        return;

This check is not needed for GraphicsContextCG because all the callers check if (m_state.strokePattern) before calling this function. But it is needed for DisplayList::Recorder and RenderSVGResourcePattern::applyResource() because the callers do not check if (m_state.strokePattern) before calling this function. So I think we should either

1. Remove the check if (m_state.strokePattern) form GraphicsContextCG functions.
2. Remove this check and make DisplayList::Recorder and RenderSVGResourcePattern::applyResource() check if (m_state.strokePattern) before calling this function.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:566
> +    if (!m_state.fillPattern)
> +        return;

Ditto.