Bug 227009 – GraphicsContext restores need to do nothing if the state stack is empty

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

GraphicsContext restores need to do nothing if the state stack is empty

[Myles C. Maxfield]

Created attachment 431397 [details]
Patch

[Tim Horton]

Comment on attachment 431397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431397&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:222
> +    if (!stackSize())
> +        return;

I think you'll want this in all of the subclasses?

[Simon Fraser (smfr)]

Comment on attachment 431397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431397&action=review

> Source/WebCore/ChangeLog:10
> +        According to the HTML spec (https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-restore-dev),
> +        "If there is no saved state, then the method must do nothing."

That's true, and the CanvasRenderingContext protects against it, but you're changing GraphicsContext.

We have thus far assumed that mismatched push/pop in GraphicsContext is a programming error.

[Myles C. Maxfield]

Created attachment 431400 [details]
Patch

[Myles C. Maxfield]

Created attachment 431407 [details]
Patch

[Myles C. Maxfield]

Created attachment 431408 [details]
Patch

[EWS]

Committed r278884 (238826@main): <https://commits.webkit.org/238826@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431408 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79352121>