| Summary: | RenderLayer::hitTestLayer assumes its renderer is a RenderBox | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||
| Component: | Layout and Rendering | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 227005, 226499 | ||||||||
| Attachments: |
|
||||||||
|
Description
Cameron McCormack (:heycam)
2021-06-14 18:55:59 PDT
Created attachment 431393 [details]
Patch
Filed bug 227005 for the followup work to make this work on inlines. shouldn't hitTestClipPath be on RenderLayerModelObject implemented by RenderBox and RenderInline (best effort) so that in RenderLayer::hitTestLayer we could just call renderer().hitTestClipPath(). It has the cost of a virtual call but this is surely not a hot codepath. Comment on attachment 431393 [details]
Patch
Alan has a suggestion
Yeah, I was looking at pulling that function up in the followup bug, but started wondering about the reference box stuff! I'll land the original is<RenderBox>() check here and do the followup work later, which turned out to be not as straightforward as I'd hoped. Created attachment 431623 [details]
Patch
Committed r278969 (238895@main): <https://commits.webkit.org/238895@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431623 [details]. |