Bug 226991

Summary: (r278359) fast/mediastream/mediaElement-gc.html is a flaky failure
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: AccessibilityAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Truitt Savell 2021-06-14 15:04:55 PDT 
fast/mediastream/mediaElement-gc.html

this test has been a flaky failure on Mac and iOS sense introduction in https://trac.webkit.org/changeset/278359/webkit 

History;
https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2FmediaElement-gc.html

Diff:
--- /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/fast/mediastream/mediaElement-gc-expected.txt
+++ /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/fast/mediastream/mediaElement-gc-actual.txt
@@ -1,4 +1,4 @@
 
 PASS Keep alive a video element with a live srcObject
-PASS GC a video element with a live srcObject, then srcObject set to null
+FAIL GC a video element with a live srcObject, then srcObject set to null assert_equals: expected 1 but got 2
Comment 1 Radar WebKit Bug Importer 2021-06-14 15:05:11 PDT 
<rdar://problem/79309901>
Comment 2 Truitt Savell 2021-06-14 15:06:51 PDT 
We should revert this change if it isn't fixed quickly
Comment 3 youenn fablet 2021-06-15 01:06:04 PDT 
Test passes consistently for release, but fails very often in debug.
I guess could restrict to release, or do several GC to get the expected result.
Comment 4 youenn fablet 2021-06-15 01:21:15 PDT 
Created attachment 431413 [details]
Patch
Comment 5 EWS 2021-06-15 07:48:04 PDT 
Committed r278874 (238818@main): <https://commits.webkit.org/238818@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431413 [details].