Bug 226985

Summary: run-javascriptcore-tests should print output when a test binary fails by default
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keith Miller 2021-06-14 12:49:51 PDT 
run-javascriptcore-tests should print output when a test binary fails by default
Comment 1 Keith Miller 2021-06-14 12:51:17 PDT 
Created attachment 431354 [details]
Patch
Comment 2 Keith Miller 2021-06-14 12:53:38 PDT 
Created attachment 431355 [details]
Patch
Comment 3 Mark Lam 2021-06-14 12:56:14 PDT 
Comment on attachment 431355 [details]
Patch

rs=me
Comment 4 EWS 2021-06-14 17:54:15 PDT 
Committed r278854 (238800@main): <https://commits.webkit.org/238800@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431355 [details].
Comment 5 Radar WebKit Bug Importer 2021-06-14 17:55:20 PDT 
<rdar://problem/79317069>
Comment 6 Darin Adler 2021-06-15 18:37:24 PDT 
Comment on attachment 431355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431355&action=review

> Tools/Scripts/run-javascriptcore-tests:642
> +    print "$testOutput" if ($verbose or $testResult);

Those quote marks don’t do anything useful.