Bug 226974

Summary: [GStreamer] gst_element_get_request_pad deprecated in 1.20
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Philippe Normand 2021-06-14 08:43:13 PDT
[13/722] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/GStreamerAudioMixer.cpp.o
../../Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp:98:31: warning: 'gst_element_get_request_pad' is deprecated: Use 'gst_element_request_pad_simple' instead [-Wdeprecated-declarations]
    auto mixerPad = adoptGRef(gst_element_get_request_pad(m_mixer.get(), "sink_%u"));
                              ^
/var/home/phil/gst-build/subprojects/gstreamer/./gst/gstelement.h:1041:23: note: 'gst_element_get_request_pad' has been explicitly marked deprecated here
extern __attribute__((__deprecated__("Use '" "gst_element_request_pad_simple" "' instead")))
                      ^
1 warning generated.
Comment 1 Philippe Normand 2021-06-14 08:44:55 PDT
Created attachment 431329 [details]
Patch
Comment 2 EWS 2021-06-16 08:16:47 PDT
Committed r278935 (238866@main): <https://commits.webkit.org/238866@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431329 [details].
Comment 3 Radar WebKit Bug Importer 2021-06-16 08:17:21 PDT
<rdar://problem/79398445>