Bug 226968

Summary: Fix RTCDataChannelInit::decode
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/29361
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Make test more reportive
none
Patch
none
Patch ews-feeder: commit-queue-

youenn fablet
Reported 2021-06-14 06:12:00 PDT
Fix RTCDataChannelInit::decode
Attachments
Patch (7.94 KB, patch)
2021-06-14 06:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (9.37 KB, patch)
2021-06-14 07:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (9.37 KB, patch)
2021-06-14 07:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Make test more reportive (8.90 KB, patch)
2021-06-15 06:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2021-06-16 01:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2021-06-17 02:34 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-06-14 06:21:47 PDT
Created attachment 431317 [details] Patch
youenn fablet
Comment 2 2021-06-14 06:22:15 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/29361
EWS Watchlist
Comment 3 2021-06-14 06:22:32 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
youenn fablet
Comment 4 2021-06-14 07:03:07 PDT
Created attachment 431320 [details] Patch
youenn fablet
Comment 5 2021-06-14 07:04:25 PDT
Created attachment 431321 [details] Patch
EWS
Comment 6 2021-06-14 11:41:02 PDT
Committed r278842 (238790@main): <https://commits.webkit.org/238790@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431321 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-14 11:42:21 PDT
<rdar://problem/79300038>
Truitt Savell
Comment 8 2021-06-14 16:21:55 PDT
the new test imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html from https://trac.webkit.org/changeset/278842/webkit is failing constantly History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebrtc-extensions%2Ftransfer-datachannel-service-worker.https.html
Truitt Savell
Comment 9 2021-06-14 16:39:41 PDT
Reverted r278842 for reason: introduced a failing test Committed r278851 (238797@main): <https://commits.webkit.org/238797@main>
youenn fablet
Comment 10 2021-06-15 06:46:58 PDT
Created attachment 431433 [details] Make test more reportive
youenn fablet
Comment 11 2021-06-16 01:37:50 PDT
Created attachment 431527 [details] Patch
youenn fablet
Comment 12 2021-06-17 02:34:23 PDT
Created attachment 431644 [details] Patch
EWS
Comment 13 2021-06-17 05:38:24 PDT
Committed r278982 (238908@main): <https://commits.webkit.org/238908@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431644 [details].
Note You need to log in before you can comment on or make changes to this bug.