| Summary: | Add fast-path for binding security check of DOMWindow | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, fpizlo, ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2021-06-11 10:53:38 PDT
Created attachment 431211 [details]
Patch
Comment on attachment 431211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review r=me > Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 > +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) Since this is a fast path, and just a pointer comparison, should we put it inline in the header? Comment on attachment 431211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review >> Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 >> +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) > > Since this is a fast path, and just a pointer comparison, should we put it inline in the header? Right! I'll move it to that. Committed r278782 (238739@main): <https://commits.webkit.org/238739@main> |