Bug 226930

Summary: Add fast-path for binding security check of DOMWindow
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, fpizlo, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+, ews-feeder: commit-queue-

Yusuke Suzuki
Reported 2021-06-11 10:53:38 PDT
Add fast-path for binding security check of DOMWindow
Attachments
Patch (6.18 KB, patch)
2021-06-11 10:56 PDT, Yusuke Suzuki 		ggaren: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-06-11 10:56:55 PDT
Created attachment 431211 [details] Patch
Geoffrey Garen
Comment 2 2021-06-11 11:09:17 PDT
Comment on attachment 431211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review r=me > Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 > +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) Since this is a fast path, and just a pointer comparison, should we put it inline in the header?
Yusuke Suzuki
Comment 3 2021-06-11 11:11:36 PDT
Comment on attachment 431211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review >> Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111 >> +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject* lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption reportingOption) > > Since this is a fast path, and just a pointer comparison, should we put it inline in the header? Right! I'll move it to that.
Yusuke Suzuki
Comment 4 2021-06-11 14:21:43 PDT
Committed r278782 (238739@main): <https://commits.webkit.org/238739@main>
Radar WebKit Bug Importer
Comment 5 2021-06-11 14:22:19 PDT
<rdar://problem/79215873>
Note You need to log in before you can comment on or make changes to this bug.