Bug 226898

Summary: Nothing is keeping navigator.xr alive during GC
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2021-06-10 14:28:37 PDT
Nothing is keeping the WebXRSystem held by navigator.xr alive during GC, so any custom properties on it will be destroyed on each collection. As Navigator object, it should use GenerateIsReachable=ReachableFromNavigator to maintain state.
Attachments
Patch (8.71 KB, patch)
2021-06-10 15:01 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (8.13 KB, patch)
2021-06-10 15:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-06-10 15:01:46 PDT
Created attachment 431137 [details] Patch
Chris Dumez
Comment 2 2021-06-10 15:04:21 PDT
Comment on attachment 431137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431137&action=review r=me > Source/WebCore/ChangeLog:8 > + Test: webxr/gc.html I think test Test: line usually comes after the description? > LayoutTests/ChangeLog:15 > +2021-06-01 Sam Weinig <weinig@apple.com> Bad double changelog. > LayoutTests/webxr/gc.html:5 > +<script src="../resources/js-test-pre.js"></script> Can use js-test.js > LayoutTests/webxr/gc.html:32 > +<script src="../resources/js-test-post.js"></script> Not needed.
Sam Weinig
Comment 3 2021-06-10 15:34:59 PDT
Created attachment 431145 [details] Patch
EWS
Comment 4 2021-06-10 20:01:07 PDT
Committed r278750 (238711@main): <https://commits.webkit.org/238711@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431145 [details].
Radar WebKit Bug Importer
Comment 5 2021-06-10 20:02:19 PDT
<rdar://problem/79175625>
Note You need to log in before you can comment on or make changes to this bug.