Bug 226878

Summary: [css-logical] Implement logical property groups
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, joepeck, koivisto, macpherson, menard, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226461, 234681    
Attachments:
Description Flags
Patch none

Oriol Brufau
Reported 2021-06-10 07:32:20 PDT
https://drafts.csswg.org/css-logical/#logical-property-group > Each set of parallel flow-relative properties and physical properties > (ignoring shorthand properties) related by setting equivalent styles > on the various sides or dimensions of a box, forms a logical property group. > For example, the padding-* properties form a single logical property group, > the margin-* properties form a separate logical property group, > the border-*-style properties form another logical property group, etc. Currently we only know the physical properties belonging to the same logical property group as a given logical property. But given a physical property, we don't know if there are logical properties that could map to it. In order to have proper CSSOM support for logical properties (bug 226461), we will need to determine whether two properties belong to the same logical property group but with a different mapping logic. So we need to implement the concept of logical property groups.
Attachments
Patch (67.63 KB, patch)
2021-06-10 07:44 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2021-06-10 07:44:32 PDT
Created attachment 431078 [details] Patch
EWS
Comment 2 2021-06-17 06:13:58 PDT
Committed r278985 (238911@main): <https://commits.webkit.org/238911@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431078 [details].
Radar WebKit Bug Importer
Comment 3 2021-06-17 06:14:47 PDT
<rdar://problem/79447519>
Note You need to log in before you can comment on or make changes to this bug.