Bug 226866

Summary:

ASSERT NOT REACHED in webcore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree()

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226696

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch	none

Ryan Haddad

Reported 2021-06-09 22:02:32 PDT

Seeing the following assert with fast/layoutformattingcontext/table-fixed-width-with-max-distribution.html https://build.webkit.org/results/Apple-BigSur-Debug-AppleSilicon-WK2-Tests/r278687%20(1599)/fast/layoutformattingcontext/table-fixed-width-with-max-distribution-stderr.txt SHOULD NEVER BE REACHED ./layout/Verification.cpp(347) : static void WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree(const WebCore::Layout::LayoutState &, const WebCore::RenderView &) 1 0x134a639ec WTFCrash 2 0x1139237f0 WTFCrashWithInfo(int, char const*, char const*, int) 3 0x116eba5c4 WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree(WebCore::Layout::LayoutState const&, WebCore::RenderView const&) 4 0x1172dc024 WebCore::FrameViewLayoutContext::layoutUsingFormattingContext() 5 0x1172be470 WebCore::FrameViewLayoutContext::layout() 6 0x1162ec0e4 WebCore::Document::implicitClose() 7 0x1170621f4 WebCore::FrameLoader::checkCallImplicitClose() 8 0x117061cdc WebCore::FrameLoader::checkCompleted() 9 0x11706024c WebCore::FrameLoader::finishedParsing() 10 0x1162ff320 WebCore::Document::finishedParsing() 11 0x116b5e6c0 WebCore::HTMLConstructionSite::finishedParsing() 12 0x116ba49e4 WebCore::HTMLTreeBuilder::finished() 13 0x116b6ec14 WebCore::HTMLDocumentParser::end() 14 0x116b6ca18 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() 15 0x116b6c7a8 WebCore::HTMLDocumentParser::prepareToStopParsing() 16 0x116b6ec84 WebCore::HTMLDocumentParser::attemptToEnd() 17 0x116b6ed40 WebCore::HTMLDocumentParser::finish() 18 0x116fecd90 WebCore::DocumentWriter::end() 19 0x116fec0d0 WebCore::DocumentLoader::finishedLoading() 20 0x116febc88 WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource&, WebCore::NetworkLoadMetrics const&) 21 0x11719d1dc WebCore::CachedResource::checkNotify(WebCore::NetworkLoadMetrics const&) 22 0x117198f40 WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*, WebCore::NetworkLoadMetrics const&) 23 0x11719a3c0 WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*, WebCore::NetworkLoadMetrics const&) 24 0x11710e334 WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&) 25 0x1024f57a4 WebKit::WebResourceLoader::didFinishResourceLoad(WebCore::NetworkLoadMetrics const&) 26 0x102c23208 void IPC::callMemberFunctionImpl<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, 0ul>(WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>&&, std::__1::integer_sequence<unsigned long, 0ul>) 27 0x102c22ffc void IPC::callMemberFunction<WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&), std::__1::tuple<WebCore::NetworkLoadMetrics>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebCore::NetworkLoadMetrics>&&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) 28 0x102c1fa9c void IPC::handleMessage<Messages::WebResourceLoader::DidFinishResourceLoad, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::NetworkLoadMetrics const&)) 29 0x102c1f480 WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) 30 0x1024b5b60 WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 31 0x100449bbc IPC::Connection::dispatchMessage(IPC::Decoder&) https://results.webkit.org/?suite=layout-tests&test=fast%2Flayoutformattingcontext%2Ftable-fixed-width-with-max-distribution.html

Attachments
Patch (1.71 KB, patch) 2021-06-10 06:35 PDT, zalan	no flags	Details Formatted Diff Diff
[fast-cq] Patch (1.81 KB, patch) 2021-06-10 06:37 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-06-09 22:03:00 PDT

<rdar://problem/79120482>

zalan

Comment 2 2021-06-10 06:33:10 PDT

I added [ Skip ] in LayoutTests/TestExpectations in the original patch but apparently there is a more specific [ ImageOnlyFailure ] in mac-wk2

zalan

Comment 3 2021-06-10 06:35:22 PDT

Created attachment 431072 [details] Patch

zalan

Comment 4 2021-06-10 06:37:16 PDT

Created attachment 431073 [details] [fast-cq] Patch

EWS

Comment 5 2021-06-10 06:39:07 PDT

Committed r278700 (238672@main): <https://commits.webkit.org/238672@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431073 [details].

Note You need to log in before you can comment on or make changes to this bug.