Summary: | [GTK] some header files not included in tarball | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | ||||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2008-12-05 11:34:17 PST
Created attachment 25778 [details]
adding files to the correct _source variables
Created attachment 25779 [details]
found another file missing, when building with soup
Comment on attachment 25779 [details]
found another file missing, when building with soup
r=me
Comment on attachment 25779 [details] found another file missing, when building with soup \ > WebCore/platform/network/soup/ResourceRequest.h \ > WebCore/platform/network/soup/ResourceResponse.h > + WebCore/platform/network/soup/CookieJarSoup. missing \ ? Landed in r39318. make distcheck is showing another error. Would you be interested in a follow up patch? Sure thing. I'll work on the follow-up patch tonight. Comment on attachment 25779 [details]
found another file missing, when building with soup
Clear the review flag.
Created attachment 26075 [details]
follow-up patch to fix one more make dist breakage
There you have it. One more file missing for make dist.
Created attachment 26090 [details]
more fixes to make dist
I found that TestNetscapePlugin was also missing some files on its SOURCES variable.
Comment on attachment 26090 [details]
more fixes to make dist
looks good.
Landed in r39405. I assume this is fixed now, we can reopen the bug if that is not the case. |