Bug 22686

Summary:

[GTK] some header files not included in tarball

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
adding files to the correct _source variables	none
found another file missing, when building with soup	none
follow-up patch to fix one more make dist breakage	none
more fixes to make dist	zecke: review+

Gustavo Noronha (kov)

Reported 2008-12-05 11:34:17 PST

While building webkit from the tarball created with make dist the following files cause errors because they are missing: ./WebCore/bindings/js/ScriptSourceCode.h ./WebCore/platform/PurgeableBuffer.h ./WebCore/bindings/js/ScriptString.h ./WebCore/bindings/js/ScriptState.h ./JavaScriptCore/assembler/MacroAssembler.h ./JavaScriptCore/wrec/Escapes.h

Attachments
adding files to the correct _source variables (2.44 KB, patch) 2008-12-05 11:35 PST, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
found another file missing, when building with soup (2.70 KB, patch) 2008-12-05 11:48 PST, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
follow-up patch to fix one more make dist breakage (1.17 KB, patch) 2008-12-16 16:04 PST, Gustavo Noronha (kov)	no flags	Details Formatted Diff Diff
more fixes to make dist (2.45 KB, patch) 2008-12-17 06:35 PST, Gustavo Noronha (kov)	zecke: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2008-12-05 11:35:57 PST

Created attachment 25778 [details] adding files to the correct _source variables

Gustavo Noronha (kov)

Comment 2 2008-12-05 11:48:28 PST

Created attachment 25779 [details] found another file missing, when building with soup

Mark Rowe (bdash)

Comment 3 2008-12-05 12:09:00 PST

Comment on attachment 25779 [details] found another file missing, when building with soup r=me

Holger Freyther

Comment 4 2008-12-15 15:58:57 PST

Comment on attachment 25779 [details] found another file missing, when building with soup \ > WebCore/platform/network/soup/ResourceRequest.h \ > WebCore/platform/network/soup/ResourceResponse.h > + WebCore/platform/network/soup/CookieJarSoup. missing \ ?

Holger Freyther

Comment 5 2008-12-15 16:11:23 PST

Landed in r39318. make distcheck is showing another error. Would you be interested in a follow up patch?

Gustavo Noronha (kov)

Comment 6 2008-12-16 06:13:01 PST

Sure thing. I'll work on the follow-up patch tonight.

Holger Freyther

Comment 7 2008-12-16 07:14:09 PST

Comment on attachment 25779 [details] found another file missing, when building with soup Clear the review flag.

Gustavo Noronha (kov)

Comment 8 2008-12-16 16:04:40 PST

Created attachment 26075 [details] follow-up patch to fix one more make dist breakage There you have it. One more file missing for make dist.

Gustavo Noronha (kov)

Comment 9 2008-12-17 06:35:06 PST

Created attachment 26090 [details] more fixes to make dist I found that TestNetscapePlugin was also missing some files on its SOURCES variable.

Holger Freyther

Comment 10 2008-12-17 13:00:28 PST

Comment on attachment 26090 [details] more fixes to make dist looks good.

Holger Freyther

Comment 11 2008-12-19 08:52:53 PST

Landed in r39405. I assume this is fixed now, we can reopen the bug if that is not the case.

Note You need to log in before you can comment on or make changes to this bug.