| Summary: | logged in GitHub issue pages have bad layout for "Notifications Customize" link | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Sergio Villar Senin <svillar> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, sam, simon.fraser, svillar, webkit-bug-importer, youennf, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar, Regression | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 190065 | ||||||||||||
| Attachments: |
|
||||||||||||
Regression is somewhere in this range: https://trac.webkit.org/log/webkit/trunk?mode=follow_copy&rev=278319&stop_rev=278253 My guess is https://trac.webkit.org/changeset/278280/webkit/trunk since it is a <summary> element that is the flex container here. Created attachment 431139 [details]
reduced test
The problem here is the https://trac.webkit.org/changeset/278280/webkit/trunk change, which makes <summary style="display: list-item;"> fall back to <summary style="display: flex;">. Should probably just revert bug 190065, it doesn't sound like it is correct. Created attachment 431186 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess I'm upstreaming the WPT test here https://github.com/web-platform-tests/wpt/pull/29341 I'll import it as part of this patch once it get the r+ Created attachment 431340 [details]
Patch
Comment on attachment 431340 [details]
Patch
OnlyCreateBlockAndFlexboxRenderers sounds very odd and indefinite :(
(In reply to zalan from comment #10) > Comment on attachment 431340 [details] > Patch > > OnlyCreateBlockAndFlexboxRenderers sounds very odd and indefinite :( Well that's already there. I guess you mean we should change it in follow up patches... Committed r278864 (238808@main): <https://commits.webkit.org/238808@main> (In reply to Sergio Villar Senin from comment #11) > (In reply to zalan from comment #10) > > Comment on attachment 431340 [details] > > Patch > > > > OnlyCreateBlockAndFlexboxRenderers sounds very odd and indefinite :( > > Well that's already there. I guess you mean we should change it in follow up > patches... I addressed it here https://trac.webkit.org/changeset/278919/webkit (In reply to zalan from comment #13) > (In reply to Sergio Villar Senin from comment #11) > > (In reply to zalan from comment #10) > > > Comment on attachment 431340 [details] > > > Patch > > > > > > OnlyCreateBlockAndFlexboxRenderers sounds very odd and indefinite :( > > > > Well that's already there. I guess you mean we should change it in follow up > > patches... > I addressed it here > https://trac.webkit.org/changeset/278919/webkit Heh, much better indeed. |
Created attachment 431031 [details] screen shot See attached screen shot. On a logged in GitHub issue page, there is a link just above the Subscribe button that says "Notifications Customize". In Firefox and Chrome, the "Notifications" is left-aligned and the "Customize" is right-aligned, all within the one line. In Safari, the "Notifications" and "Customize" run together. Probably a flexbox issue.