Bug 226828

Summary:

(r278618) media/modern-media-controls/overflow-support/chapters.html is timing out since introduction

Product:

WebKit

Reporter:

Truitt Savell <tsavell>

Component:

Media

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, eric.carlson, ews-watchlist, glenn, hhjalmarsson, hi, jbedard, jer.noble, philipj, sergio, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226902
https://bugs.webkit.org/show_bug.cgi?id=227055
https://bugs.webkit.org/show_bug.cgi?id=271785

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Truitt Savell

Reported 2021-06-09 10:24:29 PDT

the new test media/modern-media-controls/overflow-support/chapters.html added in https://trac.webkit.org/changeset/278618/webkit is a constant timeout: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

Attachments
Patch (6.98 KB, patch) 2021-06-09 13:35 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (3.04 KB, patch) 2021-06-10 14:09 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (3.99 KB, patch) 2021-06-11 14:27 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (3.99 KB, patch) 2021-06-11 15:49 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-06-09 10:24:50 PDT

<rdar://problem/79084756>

Devin Rousso

Comment 2 2021-06-09 13:35:25 PDT

Created attachment 431002 [details] Patch

EWS

Comment 3 2021-06-09 15:42:58 PDT

Committed r278678 (238657@main): <https://commits.webkit.org/238657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431002 [details].

Aakash Jain

Comment 4 2021-06-10 04:14:11 PDT

Still seems to be timing out on some platforms, e.g.: https://build.webkit.org/results/Apple-Catalina-Debug-WK2-Tests/r278698%20(2302)/results.html History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

Jonathan Bedard

Comment 5 2021-06-10 07:25:25 PDT

Much improved, but Debug queues still see occasional timeouts: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

Devin Rousso

Comment 6 2021-06-10 14:09:16 PDT

Reopening to attach new patch.

Devin Rousso

Comment 7 2021-06-10 14:09:18 PDT

Created attachment 431126 [details] Patch

EWS

Comment 8 2021-06-10 16:32:15 PDT

Committed r278739 (238701@main): <https://commits.webkit.org/238701@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431126 [details].

Jonathan Bedard

Comment 9 2021-06-11 08:40:50 PDT

Looks like we've traded timeouts for failures on debug

Devin Rousso

Comment 10 2021-06-11 14:27:17 PDT

Reopening to attach new patch.

Devin Rousso

Comment 11 2021-06-11 14:27:19 PDT

Created attachment 431232 [details] Patch

Devin Rousso

Comment 12 2021-06-11 15:49:34 PDT

Created attachment 431237 [details] Patch

EWS

Comment 13 2021-06-12 13:17:07 PDT

Committed r278814 (238767@main): <https://commits.webkit.org/238767@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431237 [details].

Truitt Savell

Comment 14 2021-06-29 15:08:13 PDT

It looks like the test has been fixed for release, but I am still seeing timeouts and failures for debug. history: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

Hercules Hjalmarsson

Comment 15 2022-07-26 13:56:54 PDT

Issue should be skipped on iOS and the timing out issue is still happening on macOS. Setting expectations and addressing issue.

EWS

Comment 16 2022-07-26 14:08:23 PDT

Test gardening commit 252842@main (8a3641cefd0d): <https://commits.webkit.org/252842@main> Reviewed commits have been landed. Closing PR #2753 and removing active labels.

Hercules Hjalmarsson

Comment 17 2022-07-26 14:10:48 PDT

(In reply to EWS from comment #16) > Test gardening commit 252842@main (8a3641cefd0d): > <https://commits.webkit.org/252842@main> > > Reviewed commits have been landed. Closing PR #2753 and removing active > labels. Removed iOS expectation for timeout in above commit. This was incorrectly set twice in https://bugs.webkit.org/show_bug.cgi?id=231187.

Note You need to log in before you can comment on or make changes to this bug.