| Summary: | [GTK] Crash when dragging an account node above WebView | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Milan Crha <mcrha> | ||||
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro, pabs3 | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Milan Crha
2021-06-09 03:50:54 PDT
(In reply to Milan Crha from comment #0) > Moving this from a downstream bug report: > https://gitlab.gnome.org/GNOME/evolution/-/issues/1526 > > In Evolution, when a user drags a mail account node above the composer > window, WebKitGTK crashes the application. The preview panel doesn't do > that. Er... where is this mail account node above the composer window? I see a combo box to select the mail account to use to send the mail, but I don't see anything dragable. > When I try the "drag above" with the MiniBrowser, then it crashes > regardless whether it's being in the editor mode or not. How exactly were you able to reproduce with MiniBrowser? Run: $ evolution -c mail there is a side bar on the left with accounts and folders. Drag the account name, like the "On This Computer", and move the mouse above the MiniBrowser content area. I'm unable to reproduce. I wonder if it is X11-specific. Are you using X11? I am using Wayland, haven't tried the MiniBrowser though. I just tried it with the `MiniBrowser --editor-mode` and `MiniBrowser` and I don't get the crash. I still do get the crash with the evolution composer window though. (In reply to Michael Catanzaro from comment #3) > I'm unable to reproduce. I wonder if it is X11-specific. Are you using X11? Right, I'm on X11 when trying with the MiniBrowser. I can partly confirm Paul comments. When on Wayland, MiniBrowser doesn't crash, but for me only when it's in the --editor-mode, where I made it crash. Its console says: $ /usr/libexec/webkit2gtk-4.0/MiniBrowser --editor-mode (MiniBrowser:2130): Gdk-WARNING **: 04:36:24.066: gdkselection-wayland.c:280: error reading selection buffer: Operation was cancelled Aborted (core dumped) (In reply to Paul Wise from comment #6) > I still do get the crash with the evolution composer window though. OK, I see the crash when dragging "On This Computer" into the composer window. *** Bug 220059 has been marked as a duplicate of this bug. *** Created attachment 431114 [details]
Patch
Problem is data with zero size is indicated by -1 in the GTK 3 implementation, but the code wasn't prepared for negative size. (The GTK 4 implementation uses unsigned integers to indicate size, and so doesn't have this problem.) Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Committed r278761 (238721@main): <https://commits.webkit.org/238721@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431114 [details]. |