Bug 226802

Summary: LayoutTests: Use os.path.dirname() instead of split('/') for Windows Python
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: cgambrell, eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, mkwst, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Fujii Hironori
Reported 2021-06-08 18:18:32 PDT
LayoutTests: Use os.path.dirname() instead of split('/') for Windows Python
Attachments
WIP patch (32.80 KB, patch)
2021-06-08 18:19 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (38.48 KB, patch)
2021-06-08 20:51 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (38.44 KB, patch)
2021-06-08 22:36 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-06-08 18:19:11 PDT
Created attachment 430930 [details] WIP patch
Fujii Hironori
Comment 2 2021-06-08 20:51:07 PDT
Created attachment 430939 [details] Patch
Fujii Hironori
Comment 3 2021-06-08 22:36:57 PDT
Created attachment 430941 [details] Patch
Jonathan Bedard
Comment 4 2021-06-09 12:57:43 PDT
Comment on attachment 430941 [details] Patch There was a weird reason we did this, the details I don't exactly remember, but had something to do with Windows (Cygwin specifically, I think) basically appending the Unix path on top of the Windows path inside Apache.....would need to fire up a Cygwin machine to double check this patch, because Chris and I are generally aware of the dangers of using split() vs dirname, this was a deliberate decision, I just don't have the specifics on hand at the moment
Fujii Hironori
Comment 5 2021-06-09 13:21:33 PDT
AppleWin EWS didn't fail. Is it a problem of the Apple internal buildbot?
Jonathan Bedard
Comment 6 2021-06-09 13:55:41 PDT
(In reply to Fujii Hironori from comment #5) > AppleWin EWS didn't fail. Is it a problem of the Apple internal buildbot? It should apply to EWS too, that's where we originally found the problem. Probably best to land and revert if needed, in that case, my exploration is unlikely to lead to something more definitive than the answer EWS has given.
Fujii Hironori
Comment 7 2021-06-09 14:04:13 PDT
Comment on attachment 430941 [details] Patch Clearing flags on attachment: 430941 Committed r278671 (238653@main): <https://commits.webkit.org/238653@main>
Fujii Hironori
Comment 8 2021-06-09 14:04:17 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 9 2021-06-09 14:04:50 PDT
Thank you. I'm going to keep my eyes on AppleWin bots.
Radar WebKit Bug Importer
Comment 10 2021-06-09 14:05:19 PDT
<rdar://problem/79097303>
Note You need to log in before you can comment on or make changes to this bug.