| Summary: | LayoutTests: Use os.path.dirname() instead of split('/') for Windows Python | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cgambrell, eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, mkwst, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 430930 [details]
WIP patch
Created attachment 430939 [details]
Patch
Created attachment 430941 [details]
Patch
Comment on attachment 430941 [details]
Patch
There was a weird reason we did this, the details I don't exactly remember, but had something to do with Windows (Cygwin specifically, I think) basically appending the Unix path on top of the Windows path inside Apache.....would need to fire up a Cygwin machine to double check this patch, because Chris and I are generally aware of the dangers of using split() vs dirname, this was a deliberate decision, I just don't have the specifics on hand at the moment
AppleWin EWS didn't fail. Is it a problem of the Apple internal buildbot? (In reply to Fujii Hironori from comment #5) > AppleWin EWS didn't fail. Is it a problem of the Apple internal buildbot? It should apply to EWS too, that's where we originally found the problem. Probably best to land and revert if needed, in that case, my exploration is unlikely to lead to something more definitive than the answer EWS has given. Comment on attachment 430941 [details] Patch Clearing flags on attachment: 430941 Committed r278671 (238653@main): <https://commits.webkit.org/238653@main> All reviewed patches have been landed. Closing bug. Thank you. I'm going to keep my eyes on AppleWin bots. |
LayoutTests: Use os.path.dirname() instead of split('/') for Windows Python