Bug 226784

Summary: [Cocoa] Remote video layer should respect video gravity when resizing
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jer.noble, philipj, sergio
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Eric Carlson 2021-06-08 14:50:01 PDT 
Remote video layer should respect video gravity when resizing
Comment 1 Eric Carlson 2021-06-08 16:53:01 PDT 
Created attachment 430910 [details]
Patch
Comment 2 Jer Noble 2021-06-09 15:36:15 PDT 
Comment on attachment 430910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430910&action=review

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:90
> +- (void) setVideoGravity:(WebCore::MediaPlayerEnums::VideoGravity)videoGravity

Nit: the spacing between (void) and setVideoGravity: is weird.

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:95
> +- (bool) resizePreservingGravity

Ditto.
Comment 3 Eric Carlson 2021-06-09 15:47:07 PDT 
Created attachment 431020 [details]
Patch
Comment 4 Eric Carlson 2021-06-10 12:21:09 PDT 
Created attachment 431107 [details]
Patch
Comment 5 Eric Carlson 2021-06-10 13:48:43 PDT 
Created attachment 431121 [details]
Patch
Comment 6 EWS 2021-06-10 16:51:46 PDT 
Committed r278740 (238702@main): <https://commits.webkit.org/238702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431121 [details].