Bug 226750

Summary: [JSC] Rename *ByIdVariant to *ByVariant and *ByKind::Normal to *ByKind::ById
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ysuzuki: review+
Patch for landing
ross.kirsling: commit-queue+
Patch for landing none

Ross Kirsling
Reported 2021-06-07 18:39:25 PDT
[JSC] Rename *ByIdVariant to *ByVariant and *ByKind::Normal to *ByKind::ById
Attachments
Patch (87.98 KB, patch)
2021-06-07 18:55 PDT, Ross Kirsling 		ysuzuki: review+
DetailsFormatted DiffDiff
Patch for landing (90.86 KB, patch)
2021-06-09 15:15 PDT, Ross Kirsling 		ross.kirsling: commit-queue+
DetailsFormatted DiffDiff
Patch for landing (90.86 KB, patch)
2021-06-09 20:56 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-06-07 18:55:55 PDT
Created attachment 430798 [details] Patch
Yusuke Suzuki
Comment 2 2021-06-09 12:09:23 PDT
Comment on attachment 430798 [details] Patch r=me. Maybe, you need rebaseline.
Ross Kirsling
Comment 3 2021-06-09 15:15:24 PDT
Created attachment 431017 [details] Patch for landing
EWS
Comment 4 2021-06-09 20:02:45 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
Ross Kirsling
Comment 5 2021-06-09 20:56:07 PDT
Created attachment 431046 [details] Patch for landing
EWS
Comment 6 2021-06-09 23:26:19 PDT
Committed r278696 (238668@main): <https://commits.webkit.org/238668@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431046 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-09 23:27:18 PDT
<rdar://problem/79123276>
Note You need to log in before you can comment on or make changes to this bug.