Summary: | Windows Python 2.7 fails to install tblib-1.7.0 due to "TypeError: environment can only contain strings" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, darin, don.olmstead, ews-watchlist, glenn, jbedard, pvollan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Fujii Hironori
2021-06-06 22:41:08 PDT
WinPort.setup_crash_log_saving modifies _NT_SYMBOL_PATH env var. And, _NT_SYMBOL_PATH constrains an unicode string. Created attachment 430712 [details]
Patch
Comment on attachment 430712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430712&action=review > Tools/ChangeLog:9 > + WinCairo port is still using Python 2.7 that has ascii strings and > + unicode strings. WinPort.setup_crash_log_saving modifies Does WinCairo port need to use Python 2? Comment on attachment 430712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430712&action=review >> Tools/ChangeLog:9 >> + unicode strings. WinPort.setup_crash_log_saving modifies > > Does WinCairo port need to use Python 2? Yes. We didn't finish Python 3 migration yet. We are working on it to remove Python 2 support. Comment on attachment 430712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430712&action=review >>> Tools/ChangeLog:9 >>> + unicode strings. WinPort.setup_crash_log_saving modifies >> >> Does WinCairo port need to use Python 2? > > Yes. We didn't finish Python 3 migration yet. We are working on it to remove Python 2 support. And for what it's worth, Apple's ports weren't ready for Python 3.8 until late last week Comment on attachment 430712 [details] Patch Clearing flags on attachment: 430712 Committed r278570 (238568@main): <https://commits.webkit.org/238568@main> All reviewed patches have been landed. Closing bug. |