Bug 226675

Summary: [WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebXRAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2021-06-04 21:06:31 PDT
[WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts
Attachments
Patch (8.50 KB, patch)
2021-06-04 21:12 PDT, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2021-06-04 21:06:56 PDT
rdar://78699437
Dean Jackson
Comment 2 2021-06-04 21:12:58 PDT
Created attachment 430641 [details] Patch
Sam Weinig
Comment 3 2021-06-05 08:18:32 PDT
Comment on attachment 430641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430641&action=review > Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:355 > + // With IOSurfaces we'll do this each frame. It would be nice if we could make these work the same for both at some point.
Dean Jackson
Comment 4 2021-06-05 14:28:30 PDT
Committed r278526 (238525@main): <https://commits.webkit.org/238525@main>
Note You need to log in before you can comment on or make changes to this bug.