Bug 226675

Summary:

[WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

WebXR

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adachan, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2021-06-04 21:06:31 PDT

[WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts

Comment 1 Dean Jackson 2021-06-04 21:06:56 PDT

rdar://78699437

Comment 2 Dean Jackson 2021-06-04 21:12:58 PDT

Created attachment 430641 [details]
Patch

Comment 3 Sam Weinig 2021-06-05 08:18:32 PDT

Comment on attachment 430641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430641&action=review

> Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:355
> +            // With IOSurfaces we'll do this each frame.

It would be nice if we could make these work the same for both at some point.

Comment 4 Dean Jackson 2021-06-05 14:28:30 PDT

Committed r278526 (238525@main): <https://commits.webkit.org/238525@main>