Weak external symbols found in WebKit.framework with Release+Coverage configuration

• Component: WebKit2
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Weak external symbols found in WebKit.framework with Release+Coverage configuration:

PhaseScriptExecution Check\ For\ Weak\ VTables\ and\ Externals WebKit.build/Release/WebKit.build/Script-5DF408C5131DD46700130071.sh
    cd Source/WebKit
    /bin/sh -c WebKit.build/Release/WebKit.build/Script-5DF408C5131DD46700130071.sh
ERROR: WebKit has a weak external symbol in it (Release/WebKit.framework/Versions/A/WebKit)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol _TCCAccessPreflight
ERROR: symbol _TCCAccessPreflightWithAuditToken
Command /bin/sh failed with exit code 1

Follow-up to Bug 226562.

[Radar WebKit Bug Importer]

<rdar://problem/78890081>

[David Kilzer (:ddkilzer)]

Created attachment 430629 [details]
Patch v1

[Alex Christensen]

Comment on attachment 430629 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=430629&action=review

> Source/WebKit/ChangeLog:3
> +        Weak external symbols found in WebKit.framework with Release+Coverage configuration

I'm happy to see activity around coverage.

> Source/WebKit/Configurations/WebKit.unexp:8
> +__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE

I wonder if these are needed any more.  I'm not sure what use of std::stringstream we have in WebKit.  Maybe we used to.  I can't imagine we are re-exporting its use from ANGLE

> Source/WebKit/Configurations/WebKit.unexp:20
> +# Methods from std::__1::function<void (WebCore::PolicyAction)> class.

These shouldn't be needed any more because we use WTF::Function for that.

> Source/WebKit/Configurations/WebKit.unexp:33
> +# Soft-linked functions in source files.  Most probably have

These should probably instead be moved to a TCCSoftLink.{h, cpp}

[David Kilzer (:ddkilzer)]

Comment on attachment 430629 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=430629&action=review

>> Source/WebKit/Configurations/WebKit.unexp:8
>> +__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
> 
> I wonder if these are needed any more.  I'm not sure what use of std::stringstream we have in WebKit.  Maybe we used to.  I can't imagine we are re-exporting its use from ANGLE

There are similar entries in WebCore.unexp.  Let's clean these up in a separate patch.

>> Source/WebKit/Configurations/WebKit.unexp:20
>> +# Methods from std::__1::function<void (WebCore::PolicyAction)> class.
> 
> These shouldn't be needed any more because we use WTF::Function for that.

I'll remove these from UNEXPORTED_SYMBOL_LDFLAGS in Configurations/WebKit.xcconfig.

>> Source/WebKit/Configurations/WebKit.unexp:33
>> +# Soft-linked functions in source files.  Most probably have
> 
> These should probably instead be moved to a TCCSoftLink.{h, cpp}

LOL...thanks for reminding me of the correct way to fix this.  It's been too long!

[David Kilzer (:ddkilzer)]

Created attachment 430655 [details]
Patch v2

[David Kilzer (:ddkilzer)]

Created attachment 430657 [details]
Patch v3

[David Kilzer (:ddkilzer)]

Created attachment 430658 [details]
Patch v4

[David Kilzer (:ddkilzer)]

Created attachment 430659 [details]
Patch v5

[EWS]

Committed r278535 (238533@main): <https://commits.webkit.org/238533@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430659 [details].