Summary: | Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'InspectorBackend.Enum.Page.ResourceType') | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, hi, inspector-bugzilla-changes, joepeck, pangle, rcaliman, timothy, webkit-bug-importer, yusufalaaothman001 | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | blob:https://twitter.com/27274f10-3876-4d84-b731-eedfd3b3c46e | ||||||||
Attachments: |
|
Description
Devin Rousso
2021-06-04 14:30:37 PDT
Created attachment 430619 [details]
Patch
Comment on attachment 430619 [details]
Patch
Testable?
(In reply to Joseph Pecoraro from comment #2) > Testable? Not really, as the tests are always either `"page"` or `"web-page"` (or don't use `InspectorBackend` at all) and therefore already had all of the domains that had enums. We maybe could do something like checking that a WK1 test has `InspectorBackend.Enum.Target.TargetInfoType` (since that's only enabled for `"web-page"`, but that seems kinda awful :/ (In reply to Devin Rousso from comment #3) > (In reply to Joseph Pecoraro from comment #2) > > Testable? > > Not really, as the tests are always either `"page"` or `"web-page"` (or don't use `InspectorBackend` at all) and therefore already had all of the domains that had enums. We maybe could do something like checking that a WK1 test has `InspectorBackend.Enum.Target.TargetInfoType` (since that's only enabled for `"web-page"`, but that seems kinda awful :/ Oh wait no I'm completely crazy yes we can add a test. Just check for `InspectorBackend.Enum.ServiceWorker` (even though there are no enums in `ServiceWorker`) :) Created attachment 430627 [details]
Patch
Committed r278512 (238511@main): <https://commits.webkit.org/238511@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430627 [details]. |