Bug 226661

Summary: Web Inspector: mark recently added protocol commands/events as page-only
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, pangle, rcaliman, saam, timothy, tzagallo, webkit-bug-importer, yusufalaaothman001
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 207446, 218964, 221228, 221449    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2021-06-04 13:34:19 PDT
.
Attachments
Patch (5.31 KB, patch)
2021-06-04 13:46 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-06-04 13:46:55 PDT
Created attachment 430609 [details] Patch
EWS Watchlist
Comment 2 2021-06-04 13:47:58 PDT
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Joseph Pecoraro
Comment 3 2021-06-04 13:50:40 PDT
Comment on attachment 430609 [details] Patch rs=me, Can a Service Worker debugger do intercepts?
Joseph Pecoraro
Comment 4 2021-06-04 13:52:14 PDT
Comment on attachment 430609 [details] Patch Given existing intercept methods are only for "page" this seems good! r=me
Devin Rousso
Comment 5 2021-06-04 15:04:25 PDT
(In reply to Joseph Pecoraro from comment #3) Can a Service Worker debugger do intercepts? I tried enabling all the intercept commands for `"service-worker"` targets too, but it didn't work. Also, most "resources" are actually `WI.Script` that don't have a `WI.Resource` and therefore don't go through the `Network` agent.
EWS
Comment 6 2021-06-04 16:57:46 PDT
Committed r278511 (238510@main): <https://commits.webkit.org/238510@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430609 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-04 16:58:19 PDT
<rdar://problem/78892294>
Note You need to log in before you can comment on or make changes to this bug.