Bug 226654

Summary:

Replace invalidSnapOffsetIndex with std::optional<unsigned>

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Scrolling

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

226630

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Martin Robinson 2021-06-04 11:27:13 PDT

Using std::optional<unsigned> instead of UINT_MAX to indicate when there is no selected scroll offset will more easily prevent errors in the code.

Comment 1 Radar WebKit Bug Importer 2021-06-11 11:28:43 PDT

<rdar://problem/79208115>

Comment 2 Martin Robinson 2021-06-15 04:48:30 PDT

Created attachment 431423 [details]
Patch

Comment 3 Martin Robinson 2021-06-15 06:31:57 PDT

Created attachment 431432 [details]
Patch

Comment 4 EWS 2021-06-16 00:37:57 PDT

Committed r278923 (238854@main): <https://commits.webkit.org/238854@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431432 [details].