Summary: | Compile errors by unexpected values in ANGLE functions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eleni Maria Stea <estea> | ||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, dino, ews-watchlist, graouts, Hironori.Fujii, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Eleni Maria Stea
2021-06-04 04:08:13 PDT
Created attachment 430567 [details]
Patch
ANGLE seems to use int64_t and uint64_t. What about changing GCGLint64 and GCGLuint64? typedef int64_t GCGLint64; typedef uint64_t GCGLuint64; (In reply to Fujii Hironori from comment #2) > ANGLE seems to use int64_t and uint64_t. > What about changing GCGLint64 and GCGLuint64? > > typedef int64_t GCGLint64; > typedef uint64_t GCGLuint64; This sounds like a good solution sure, I am going to update it Created attachment 430735 [details]
Patch
The failures on mac-AS-debug-wk2 look unrelated: Application Specific Information: CRASHING TEST: /canvas/webgl/origin-clean-conformance.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000103235374 WTFCrash + 20 1 com.apple.WebCore 0x00000001200c0e70 WTFCrashWithInfo(int, char const*, char const*, int) + 32 2 com.apple.WebCore 0x0000000121559bd4 WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken(WebCore::SharedRoutingArbitrator::Token const&) + 124 3 com.apple.WebKit 0x000000010ce7a068 WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration() + 68 4 com.apple.WebKit 0x000000010b7c64b4 void IPC::callMemberFunctionImpl<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<> >(WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>) + 124 5 com.apple.WebKit 0x000000010b7c5fe0 void IPC::callMemberFunction<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) + 124 6 com.apple.WebKit 0x000000010b7c2a14 void IPC::handleMessage<Messages::AudioSessionRoutingArbitratorProxy::EndRoutingArbitration, WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()>(IPC::Decoder&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) + 160 7 com.apple.WebKit 0x000000010b7c2778 WebKit::AudioSessionRoutingArbitratorProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 200 8 com.apple.WebKit 0x000000010bd5f6cc IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 384 9 com.apple.WebKit 0x000000010cd96ac8 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 44 10 com.apple.WebKit 0x000000010d09600c WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 48 Comment on attachment 430735 [details]
Patch
Looks good to me given that this change compiles. r+
Committed r278571 (238569@main): <https://commits.webkit.org/238569@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430735 [details]. |