Summary: | fast/dom/Window/property-access-on-cached-window-after-frame-removed.html (layout-test) may crash | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||
Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=226570 | ||||||||
Attachments: |
|
Description
Jean-Yves Avenard [:jya]
2021-06-03 17:40:23 PDT
Created attachment 430531 [details]
Patch
Created attachment 430534 [details]
Patch
Committed r278448 (238468@main): <https://commits.webkit.org/238468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430534 [details]. Comment on attachment 430534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430534&action=review > Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h:52 > + WEBCORE_EXPORT static Ref<MediaSessionCoordinator> create(ScriptExecutionContext*); Since we were changing this, it might have been good to make this take a reference instead of a pointer too. Next time, I guess. > Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h:76 > + MediaSessionCoordinator(ScriptExecutionContext*); In a situation like this I suggest we add "explicit" now that the constructor has only a single argument. In practice it’s not critical since this is private anyway, and doing a conversion by accident is unlikely. Comment on attachment 430534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430534&action=review >> Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h:76 >> + MediaSessionCoordinator(ScriptExecutionContext*); > > In a situation like this I suggest we add "explicit" now that the constructor has only a single argument. In practice it’s not critical since this is private anyway, and doing a conversion by accident is unlikely. This is an oversight, I should have done so. We should have a static analyser enforcing the rule that single argument constructor must be made explicit. |