Bug 226590

Summary: Compile error in HTML canvas when both OpenGL and WebGL2 are used in GTKPlatform
Product: WebKit Reporter: Eleni Maria Stea <estea>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: aperez, bugs-noreply, cdumez, changseok, dino, esprehn+autocc, estea, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eleni Maria Stea
Reported 2021-06-03 10:41:43 PDT
Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: In function WebGLRenderingContextBase::drawElements m_context is of type GraphicsContextGL which doesn't have any primitiveRestartIndex function. Context should be accessed as GraphicsContextGLOpenGL to call this function otherwise a compile error is generated.
Attachments
Patch (1.67 KB, patch)
2021-06-03 10:55 PDT, Eleni Maria Stea 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eleni Maria Stea
Comment 1 2021-06-03 10:55:34 PDT
Created attachment 430483 [details] Patch
Adrian Perez
Comment 2 2022-02-28 13:57:02 PST
Patch not needed anymore, primitiveRestartIndex() is not used anymore from WebCore these days.
Note You need to log in before you can comment on or make changes to this bug.