Bug 226572

Summary: [css-scroll-snap] Scroll snap offsets are interpreted as scroll positions in ScrollableArea
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218115    
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2021-06-03 02:05:48 PDT
In ScrollableArea when there is an initial scroll-snap offset or while resnapping after layout, scroll offsets are interpreted as scroll positions. This leads to incorrect scroll positions when dealing with RTL layouts.
Attachments
Patch (8.22 KB, patch)
2021-06-03 05:32 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2021-06-15 01:26 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-06-03 05:32:44 PDT
Created attachment 430462 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-06-03 10:18:47 PDT
Comment on attachment 430462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430462&action=review Please check the test failures. > Source/WebCore/platform/ScrollableArea.cpp:516 > +IntPoint ScrollableArea::nearestActiveSnapPoint(const IntPoint& currentOffset) Maybe we should rename this nearestActiveSnapPointForOffset(). The argument should be a ScrollOffset.
Martin Robinson
Comment 3 2021-06-04 00:24:47 PDT
It looks like these Mac failures are due to a related issue at bug 226630. I have a fix for that, but it depends on bug 226538.
Radar WebKit Bug Importer
Comment 4 2021-06-10 02:06:19 PDT
<rdar://problem/79128519>
Martin Robinson
Comment 5 2021-06-15 01:26:10 PDT
Created attachment 431414 [details] Patch
EWS
Comment 6 2021-06-15 04:09:43 PDT
Committed r278868 (238812@main): <https://commits.webkit.org/238812@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431414 [details].
Note You need to log in before you can comment on or make changes to this bug.