Bug 226568

Summary:

Add MediaSessionCoordinator test to ensure that disconnection on the private side is properly handled.

Product:

WebKit

Reporter:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Component:

Media

Assignee:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jean-Yves Avenard [:jya] 2021-06-02 23:57:48 PDT

We don't currently have a test to ensure that when the MediaSessionCoordinatorPrivate in the UI process is disconnected or switch to the closed state that the MediaSessionCoordinator in the web process properly signals JS that the session got closed.

Let's add a test for it.

Comment 1 Radar WebKit Bug Importer 2021-06-03 00:04:58 PDT

<rdar://problem/78801408>

Comment 2 Jean-Yves Avenard [:jya] 2021-06-03 00:31:25 PDT

Created attachment 430447 [details]
Patch

Comment 3 Eric Carlson 2021-06-03 09:01:28 PDT

Comment on attachment 430447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430447&action=review

> Source/WebCore/ChangeLog:12
> +        * Modules/mediasession/MediaSessionCoordinatorPrivate.h: Add coordinatorStateChanged method,
> +        will forward state to RemoteMediaSessionCoordinatorProxy::coordinatorStateChanged.

Nit: this comment isn't accurate.

Comment 4 EWS 2021-06-03 15:27:20 PDT

Committed r278423 (238447@main): <https://commits.webkit.org/238447@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430447 [details].