Bug 226564

Summary: [WebXR] Supply an IOSurface in SimulatedXRDevice
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebXRAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2021-06-02 18:34:50 PDT
Supply an IOSurface in SimulatedXRDevice
Attachments
Patch (2.75 KB, patch)
2021-06-02 18:36 PDT, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-02 18:35:02 PDT
<rdar://problem/78793086>
Dean Jackson
Comment 2 2021-06-02 18:36:57 PDT
Created attachment 430431 [details] Patch
Sam Weinig
Comment 3 2021-06-03 08:10:41 PDT
Comment on attachment 430431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430431&action=review > Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:119 > + ASSERT(data.surface); Maybe consider making surface a UniqueRef? > Source/WebCore/testing/WebFakeXRDevice.cpp:154 > + auto surface = IOSurface::create(recommendedResolution(PlatformXR::SessionMode::ImmersiveVr), DestinationColorSpace::SRGB()); > + data.layers.add(layer.key, FrameData::LayerData { .surface = WTFMove(surface) }); I would do this in one line.
Dean Jackson
Comment 4 2021-06-05 16:32:23 PDT
Committed r278528 (238527@main): <https://commits.webkit.org/238527@main>
Note You need to log in before you can comment on or make changes to this bug.